-
Notifications
You must be signed in to change notification settings - Fork 14k
Bump compiler dependencies #148831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compiler dependencies #148831
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? me |
ffd3051 to
0e471f5
Compare
|
If the Unicode version changes are intentional, cc @ehuss |
|
I'll open a reference PR for the Unicode change if this looks good |
0e471f5 to
ba8a32b
Compare
This comment has been minimized.
This comment has been minimized.
ba8a32b to
dd42eac
Compare
|
Backed out those changes in favour of #148321 |
|
Unsure what the status of this PR is
... Wait, does this only modify the lockfile? Can we explicitly pin those deps? Also, that seems a bit concerning, because if those deps release a point release for $bug, we won't be able to bump without introducing the binary blobs (if I'm understanding what you're saying) right? |
|
☔ The latest upstream changes (presumably #147918) made this pull request unmergeable. Please resolve the merge conflicts. |
There's some discussion here. The relevant dep is 'pinned' in the tidy license checker (though this is complicated by the blob being moved to a different crate). The motivation for doing it like this vs a direct Cargo.toml dep is:
|
dd42eac to
2311693
Compare
This comment has been minimized.
This comment has been minimized.
|
Added some pinning in Cargo.toml to try and avoid these bumps in @rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup=iffy |
…=jieyouxu Bump compiler dependencies rust-lang#145849 (comment) This manually downgrades the `wasip`/`wit-bindgen`/`getrandom` deps to avoid pulling in a binary blob, but it would be good to pin this automatically in a way which doesn't cause these blobs to be pulled in.
Rollup of 10 pull requests Successful merges: - #146925 (Add doc for va_list APIs) - #147035 (alloc: fix `Debug` implementation of `ExtractIf`) - #147173 (Add support for hexagon-unknown-qurt target) - #148261 (rustc_public: Make Id types !Send / !Sync) - #148831 (Bump compiler dependencies) - #149041 (ignore unsized types in mips64 and sparc64 callconvs) - #149056 (fix the fragment_in_dst_padding_gets_overwritten test on s390x) - #149071 (Add test scaffolding for the `remote-test-client`) - #149095 (rustc-dev-guide subtree update) - #149108 ([AIX][ppc64le-linux-gnu] Add Amy Kwan to target maintainers) r? `@ghost` `@rustbot` modify labels: rollup
|
looks like this failed here #149124 (comment) |
|
cc @a1phyr (rust-lang/backtrace-rs#727 seems most likely to be the change causing this). Any idea why the ABI might be mismatched? |
|
@bors try jobs=x86_64-msvc-ext2 |
This comment has been minimized.
This comment has been minimized.
Bump compiler dependencies try-job: x86_64-msvc-ext2
|
microsoft/windows-rs#3741 / windows-link 0.2 removed the ABI overwriting behaviour, so backtrace-rs will need updating to account for that iiuc |
e7c78b5 to
36bdffe
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=jieyouxu rollup=iffy |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 27b076a (parent) -> 5934b06 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 5934b0655768a45aad237a704995780276b91261 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (5934b06): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.357s -> 470.656s (-0.57%) |
#145849 (comment)
This manually downgrades the
wasip/wit-bindgen/getrandomdeps to avoid pulling in a binary blob, but it would be good to pin this automatically in a way which doesn't cause these blobs to be pulled in.