add test for assoc type norm wf check #148783
Merged
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 10, 2025
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
BoxyUwU
reviewed
Nov 10, 2025
|
|
||
| // Add GAT where clauses from the trait's definition. | ||
| // FIXME: We don't need these, since these are the type's own WF obligations. | ||
| // Add GAT where clauses from the trait's definition.This is necessary for soundness, |
Member
There was a problem hiding this comment.
"This is necessary for soundness until we properly handle implied bounds on binders" or sth?
Contributor
Author
There was a problem hiding this comment.
hmm, I've already put this in the test, u want me to also add that comment here?
Member
There was a problem hiding this comment.
speaking for myself if i read these comments ill probably go "hmm that feels kinda iffy" and get confused and spend a few minutes wasting time before figuring out whats going on (e.g. from reading the test). i don't care too much though so feel free to r=me if you don't think its worth writing in the comments too
BoxyUwU
added
S-waiting-on-author
lcnr
force-pushed
the
add-soundness-test
branch
from
a2ea8ad to
2570c23
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=BoxyUwU |
Collaborator
bors
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 11, 2025
add test for assoc type norm wf check This is soundness critical 😁 sure is helpful to have tests for that. cc `@rust-lang/types` r? `@BoxyUwU`
bors
added a commit
that referenced
this pull request
Nov 11, 2025
Rollup of 13 pull requests Successful merges: - #148694 (std: support `RwLock` and thread parking on TEEOS) - #148712 (Port `cfg_select!` to the new attribute parsing system) - #148760 (rustc_target: hide TargetOptions::vendor) - #148771 (IAT: Reinstate early bailout) - #148775 (Fix a typo in the documentation for the strict_shr function) - #148779 (Implement DynSend and DynSync for std::panic::Location.) - #148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`) - #148783 (add test for assoc type norm wf check) - #148785 (Replace `master` branch references with `main`) - #148791 (fix "is_closure_like" doc comment) - #148792 (Prefer to use file.stable_id over file.name from source map) - #148805 (rustc-dev-guide subtree update) - #148807 (Document (and test) a problem with `Clone`/`Copy` deriving.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 11, 2025
Rollup merge of #148783 - lcnr:add-soundness-test, r=BoxyUwU add test for assoc type norm wf check This is soundness critical 😁 sure is helpful to have tests for that. cc ``@rust-lang/types`` r? ``@BoxyUwU``
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 12, 2025
Rollup of 13 pull requests Successful merges: - rust-lang/rust#148694 (std: support `RwLock` and thread parking on TEEOS) - rust-lang/rust#148712 (Port `cfg_select!` to the new attribute parsing system) - rust-lang/rust#148760 (rustc_target: hide TargetOptions::vendor) - rust-lang/rust#148771 (IAT: Reinstate early bailout) - rust-lang/rust#148775 (Fix a typo in the documentation for the strict_shr function) - rust-lang/rust#148779 (Implement DynSend and DynSync for std::panic::Location.) - rust-lang/rust#148781 ([rustdoc] Remove unneeded `allow(rustc::potential_query_instability)`) - rust-lang/rust#148783 (add test for assoc type norm wf check) - rust-lang/rust#148785 (Replace `master` branch references with `main`) - rust-lang/rust#148791 (fix "is_closure_like" doc comment) - rust-lang/rust#148792 (Prefer to use file.stable_id over file.name from source map) - rust-lang/rust#148805 (rustc-dev-guide subtree update) - rust-lang/rust#148807 (Document (and test) a problem with `Clone`/`Copy` deriving.) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is soundness critical 😁 sure is helpful to have tests for that. cc @rust-lang/types
r? @BoxyUwU