Skip to content

Conversation

@GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Nov 6, 2025

Tracking issue: #135894

Waiting for FCP: #135894 (comment)
@rustbot label +S-waiting-on-FCP

1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: #135894 (comment)

Closes #135894

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Nov 6, 2025
@hanna-kruppe
Copy link
Contributor

I would suggest splitting out the lint change into a separate PR. It would be useful even before stabilization, I don't think it requires its own FCP, and it'll make the API stabilization itself a bit easier to review. That's especially important since the simultaneous deprecation makes it a big and tricky diff by stabilization standards!

@GrigorenkoPV
Copy link
Contributor Author

Good idea!

Done: #148601

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
…ng, r=Kivooeo

`invalid_atomic_ordering`: also lint `update` & `try_update`

Split from rust-lang#148590

Tracking issue for `update` and `try_update`: rust-lang#135894
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
…ng, r=Kivooeo

`invalid_atomic_ordering`: also lint `update` & `try_update`

Split from rust-lang#148590

Tracking issue for `update` and `try_update`: rust-lang#135894
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 9, 2025
…ng, r=Kivooeo

`invalid_atomic_ordering`: also lint `update` & `try_update`

Split from rust-lang#148590

Tracking issue for `update` and `try_update`: rust-lang#135894
rust-timer added a commit that referenced this pull request Nov 9, 2025
Rollup merge of #148601 - GrigorenkoPV:invalid_atomic_ordering, r=Kivooeo

`invalid_atomic_ordering`: also lint `update` & `try_update`

Split from #148590

Tracking issue for `update` and `try_update`: #135894
and deprecate fetch_update starting 1.96.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for atomic_try_update

3 participants