Implement the MCP 932: Promote riscv64a23-unknown-linux-gnu to Tier 2 #148435
Conversation
… without host tools Changes: - Update target tier from 3 to 2 in target specification - Update platform documentation - Add CI/CD support for automatic building and distribution via rustup
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
rustbot
added
A-CI
| sudo apt-get install gcc-riscv64-linux-gnu | ||
|
|
||
| # Then set the linker | ||
| RUSTFLAGS="-C linker=riscv64-linux-gnu-gcc" cargo build --target=riscv64a23-unknown-linux-gnu |
There was a problem hiding this comment.
Does the target work with lld? If so, it may be better to set rust-lld as the default linker instead asking users to use an external linker.
There was a problem hiding this comment.
Thanks for the review!
This target works with rust-lld. From my understanding, the default linker should be configured by targets that provide host tools for cross-compilation, rather than by the target itself. If I'm wrong about this, please share more guidance.
There was a problem hiding this comment.
Well, looking at our target definitions many of have linker: Some("rust-lld".into()) set and most of them do not provide host tools, including some RISC-V targets123. So I think it would make for this target to also set rust-lld as it's default linker.
Footnotes
-
https://github.com/rust-lang/rust/blob/e5efc336720901420a8891dcdb67ca0a475dc03c/compiler/rustc_target/src/spec/targets/riscv32e_unknown_none_elf.rs#L23-L24 ↩
-
https://github.com/rust-lang/rust/blob/e5efc336720901420a8891dcdb67ca0a475dc03c/compiler/rustc_target/src/spec/targets/riscv32emc_unknown_none_elf.rs#L23-L24 ↩
-
https://github.com/rust-lang/rust/blob/e5efc336720901420a8891dcdb67ca0a475dc03c/compiler/rustc_target/src/spec/targets/riscv32imac_unknown_xous_elf.rs#L20-L21 ↩
4 participants
Implement the MCP 932: Promote riscv64a23-unknown-linux-gnu to Tier 2 without host tools.
Changes:
r? jieyouxu
cc @davidtwco @Noratrieb