Skip to content

Fix some issues around rustc_public #148358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix some issues around rustc_public #148358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084c492
rustc_public: make the `unstable` module public
makai410 Nov 1, 2025
fc3057b
rustc_public: add `#[cfg(feature = "rustc_internal")]` to `compiler_i…
makai410 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/rustc_public/src/compiler_interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,8 @@ impl<'tcx> CompilerInterface<'tcx> {
// A thread local variable that stores a pointer to [`CompilerInterface`].
scoped_tls::scoped_thread_local!(static TLV: Cell<*const ()>);

// FIXME(makai410): remove this cfg when we have a stable driver.
Copy link
Contributor

@celinval celinval Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this FIXME... Maybe just a comment. We could also move this function to be inside rustc_internal.

#[cfg(feature = "rustc_internal")]
pub(crate) fn run<'tcx, F, T>(interface: &CompilerInterface<'tcx>, f: F) -> Result<T, Error>
where
F: FnOnce() -> T,
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_public/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ use crate::unstable::Stable;

pub mod abi;
mod alloc;
pub(crate) mod unstable;
pub mod unstable;
Copy link
Contributor

@celinval celinval Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should make this module public. Instead, we should add an attribute to the trait declarations:

/// This is used by the public `rustc_internal::stable` function when feature `rustc_internal` is enabled.
#[cfg_attr(not(feature = "rustc_internal"), allow(unreachable_pub))]
pub trait Stable<'tcx>: PointeeSized {
  // ...
}

#[macro_use]
pub mod crate_def;
pub mod compiler_interface;
Expand Down
Loading