Show backtrace on allocation failures when possible #148020
Conversation
And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed.
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
library/std/src/alloc.rs
Outdated
| let mut lock = crate::sys::backtrace::lock(); | ||
|
|
||
| match crate::panic::get_backtrace_style() { | ||
| // SAFETY: we took out a lock just a second ago. |
There was a problem hiding this comment.
It's not clear to me what this safety comment is on - I don't see any unsafe code here?
There was a problem hiding this comment.
BacktraceLock::print is incorrectly marked as safe. It and all callers should be marked unsafe. See 1c8f9bb?w=1#diff-1b221b9e32f6143fdd8a5505c8893377e8e9eb1ff47b988716343c7e70393b1bR40.
There was a problem hiding this comment.
Why is it not safe? The mere fact that you have a BacktraceLock (which you need to call print) means that no other thread can be printing a backtrace, right?
There was a problem hiding this comment.
oh, right. probably the safety comment should just be moved inside that function then?
5 participants
And if an allocation while printing the backtrace fails, don't try to print another backtrace as that will never succeed.
Split out of #147725 to allow landing this independently of a decision whether or not to remove
-Zoom=panic.