Skip to content

PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+ #147948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2025
Merged

PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+ #147948

merged 4 commits into from
Oct 22, 2025
+15 −6

Conversation

@aeubanks
Copy link
Contributor

@aeubanks aeubanks commented Oct 21, 2025 •
edited
Loading

llvm/llvm-project#164355 makes SummaryList private and provides a getter method.

@rustbot label llvm-main

@aeubanks
PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter fo…
fc7c4be 
…r LLVM 22+

llvm/llvm-project#164355 makes SummaryList private and provides a getter method.

@rustbot label llvm-main
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@aeubanks aeubanks changed the title PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter fo… PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+ Oct 21, 2025
@aeubanks
Copy link
Contributor Author

r? @durin42

@rustbot rustbot assigned durin42 and unassigned cuviper Oct 21, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@durin42 durin42 added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Oct 21, 2025
@durin42
Copy link
Contributor

durin42 commented Oct 21, 2025

This doesn't compile, either for me locally or on buildkite:

https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/40828#019a08b7-6dd6-4ae1-8b25-ef0aca5d3b8e

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@aeubanks
Copy link
Contributor Author

This doesn't compile, either for me locally or on buildkite:

https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/40828#019a08b7-6dd6-4ae1-8b25-ef0aca5d3b8e

sorry about that, hopefully fixed

@durin42
Copy link
Contributor

durin42 commented Oct 21, 2025

@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Oct 21, 2025

📌 Commit 1e80546 has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 22, 2025
Merged
bors added a commit that referenced this pull request Oct 22, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
b2ee1b3 
Rollup of 7 pull requests

Successful merges:

 - #141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - #142339 (Add NonNull pattern types)
 - #147768 (Code refactoring on hir report_no_match_method_error)
 - #147788 (const Cell methods)
 - #147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - #147933 (os_str: Make platform docs more consistent)
 - #147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e132d2d into rust-lang:master Oct 22, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 22, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 23, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
698b2f9 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
 - rust-lang/rust#142339 (Add NonNull pattern types)
 - rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
 - rust-lang/rust#147788 (const Cell methods)
 - rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
 - rust-lang/rust#147933 (os_str: Make platform docs more consistent)
 - rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@durin42 durin42

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@aeubanks @rustbot @rust-log-analyzer @durin42 @bors @cuviper