Update list of available search filters in help menu #147909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
S-waiting-on-review
rustbot
added
the
T-rustdoc-frontend
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
help-search-filters
branch
from
0de197d to
833a49a
Compare
|
r? @notriddle |
|
Ick, no. That is way too long for a flat list like that. Maybe, instead?
|
|
I wanted something similar originally but that would make it too "tall". Gonna need to think how to present that in a better shape without taking too much height. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 29, 2025
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? `@notriddle`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Oct 30, 2025
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ``@notriddle``
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Oct 30, 2025
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
rust-timer
added a commit
that referenced
this pull request
Oct 30, 2025
Rollup merge of #148176 - GuillaumeGomez:filter-macros, r=notriddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for #148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 1, 2025
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? `@notriddle`
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 1, 2025
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ``@notriddle``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 1, 2025
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ```@notriddle```
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 1, 2025
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ````@notriddle````
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 1, 2025
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? `````@notriddle`````
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized that the help menu mentions the list of available search item type filters... but it's also very incomplete and the book says the full list is provided there.
Considering that
search.jsis supposed to be self-contained (for our testsuite mostly) and that we don't want to add an extra step to generate JS (so we can copy-paste it around and just test it), I'm not too sure what would be the best solution here.Anyway, question for future us, in the meantime, this adds the missing entries in the help menu:
r? @lolbinarycat