enzyme/autodiff is compatible with download-ci=true #147888
Merged
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
This was referenced Oct 19, 2025
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
ZuseZ4
force-pushed
the
autodiff-with-download-ci
branch
from
55d9799 to
3e32dc2
Compare
jieyouxu
approved these changes
Oct 20, 2025
There was a problem hiding this comment.
However, shouldn't download-ci-llvm already be the default? Why do I still have to manually set it with this pr?
Probably because ./configure tries to be very conservative (to a dist profile or global default). download-ci-llvm is a reasonable default for development profiles, but is not suitable as a global default, so you'll ned to opt-in like you are doing here.
Thanks.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 20, 2025
Rollup of 4 pull requests Successful merges: - #147734 (Further tighten up relaxed bounds) - #147888 (enzyme/autodiff is compatible with download-ci=true) - #147898 (compiletest: Move `AuxProps` out of `EarlyProps`) - #147903 (compiletest: Store the selected edition in `TestProps`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 20, 2025
Rollup merge of #147888 - ZuseZ4:autodiff-with-download-ci, r=jieyouxu enzyme/autodiff is compatible with download-ci=true To my surprise autodiff just works out of the box with download-ci=true. Thanks to all the bootstrap people who over the past helped me to link properly against the sysroot LLVM, which seems to pay off here. That also helps with enabling Rust in Enzyme CI, since CCache for some reason doesn't seem to cache LLVM correctly on their runners. I verified that this works with ` ./configure --release-channel=nightly --enable-llvm-enzyme --enable-option-checking --disable-docs --enable-llvm-assertions --set llvm.download-ci-llvm=true`. However, shouldn't download-ci-llvm already be the default? Why do I still have to manually set it with this pr? I tested it afterwards with `./x.py test --stage 1 tests/codegen-llvm/autodiff` r? bootstrap closes #147535
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 20, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#147734 (Further tighten up relaxed bounds) - rust-lang/rust#147888 (enzyme/autodiff is compatible with download-ci=true) - rust-lang/rust#147898 (compiletest: Move `AuxProps` out of `EarlyProps`) - rust-lang/rust#147903 (compiletest: Store the selected edition in `TestProps`) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To my surprise autodiff just works out of the box with download-ci=true. Thanks to all the bootstrap people who over the past helped me to link properly against the sysroot LLVM, which seems to pay off here.
That also helps with enabling Rust in Enzyme CI, since CCache for some reason doesn't seem to cache LLVM correctly on their runners.
I verified that this works with
./configure --release-channel=nightly --enable-llvm-enzyme --enable-option-checking --disable-docs --enable-llvm-assertions --set llvm.download-ci-llvm=true. However, shouldn't download-ci-llvm already be the default? Why do I still have to manually set it with this pr?I tested it afterwards with
./x.py test --stage 1 tests/codegen-llvm/autodiffr? bootstrap
closes #147535