Skip to content

Conversation

Muscraft
Copy link
Member

I saw that typos was a few versions out of date and figured it would be a good idea to update it. Upgrading to 1.38.1 adds the July, August, and September dictionary updates. As part of this change, I also sorted the configuration file.

@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

tidy extra checks were modified.

cc @lolbinarycat

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Oct 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 17, 2025
@rust-log-analyzer

This comment has been minimized.

@oli-obk
Copy link
Contributor

oli-obk commented Oct 18, 2025

r? @Noratrieb or reassign (I just think you know who to assign to xD)

@rustbot rustbot assigned Noratrieb and unassigned petrochenkov Oct 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2025

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@@ -1,8 +1,8 @@
error[E0277]: the type `UnsafeCell<i32>` may contain interior mutability and a reference may not be safely transferrable across a catch_unwind boundary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's cool, in an error message

@Noratrieb
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 22, 2025

📌 Commit 12f6b96 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 22, 2025
@bors
Copy link
Collaborator

bors commented Oct 22, 2025

⌛ Testing commit 12f6b96 with merge 4d94478...

@bors
Copy link
Collaborator

bors commented Oct 22, 2025

☀️ Test successful - checks-actions
Approved by: Noratrieb
Pushing 4d94478 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 22, 2025
@bors bors merged commit 4d94478 into rust-lang:master Oct 22, 2025
12 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 22, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f5e2df7 (parent) -> 4d94478 (this PR)

Test differences

Show 8 test diffs

Stage 0

  • errors::verify_builtin_macros_source_uitls_expected_item_86: pass -> [missing] (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_86: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_source_uitls_expected_item_86: pass -> [missing] (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_86: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4d94478977b5d6c0caa1e66390c6b137520af368 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6113.6s -> 7138.8s (16.8%)
  2. x86_64-rust-for-linux: 3172.6s -> 2725.9s (-14.1%)
  3. dist-armhf-linux: 5824.0s -> 5071.9s (-12.9%)
  4. aarch64-gnu-llvm-20-2: 2566.4s -> 2239.2s (-12.7%)
  5. dist-x86_64-apple: 7744.3s -> 6778.5s (-12.5%)
  6. x86_64-gnu-llvm-20: 2830.3s -> 2501.8s (-11.6%)
  7. x86_64-gnu-llvm-20-1: 3275.5s -> 3607.7s (10.1%)
  8. aarch64-msvc-1: 7659.6s -> 6954.7s (-9.2%)
  9. tidy: 181.2s -> 197.8s (9.2%)
  10. dist-apple-various: 4066.8s -> 3723.7s (-8.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Muscraft Muscraft deleted the update-typos branch October 22, 2025 16:25
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (4d94478): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.8% [3.3%, 4.3%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.978s -> 473.902s (0.20%)
Artifact size: 390.71 MiB -> 390.68 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants