- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
constify comparison traits on slices #147790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
| This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. | 
| @bors r+ rollup | 
constify comparison traits on slices r? oli-obk Tracking issue rust-lang#143800
Rollup of 6 pull requests Successful merges: - #147406 (Remove needs-asm-support directive in tests with explicit targets) - #147790 (constify comparison traits on slices) - #148056 (refactor(rustdoc): Remove redundant langstr checks) - #148065 (compiletest: Add concrete examples for some config/test path fields) - #148072 (Fix compiling `CondVar::wait_timeout` on 32-bit Apple platforms) - #148073 (test(frontmatter): Rename tests to make coverage more obvious) r? `@ghost` `@rustbot` modify labels: rollup
r? oli-obk
Tracking issue #143800