Skip to content

Return Option from exact_div and inherit overflow checks #147784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 2, 2025
Merged

Return Option from exact_div and inherit overflow checks #147784

merged 2 commits into from
Nov 2, 2025

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Oct 16, 2025 •
edited by rustbot
Loading

According to #139911 (comment), exact_div should return Option::None if self % rhs != 0, panic if rhs == 0, and handle overflow conditionally (panic in debug, wrap in release).

#147771 should rename exact_div to div_exact.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken
Copy link
Contributor Author

nxsaken commented Oct 31, 2025

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Oct 31, 2025
@rustbot rustbot assigned dtolnay and unassigned scottmcm Oct 31, 2025
dtolnay
dtolnay approved these changes Nov 2, 2025
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@dtolnay
Copy link
Member

dtolnay commented Nov 2, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 2, 2025

📌 Commit e834a2e has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2025
@bors
Copy link
Collaborator

bors commented Nov 2, 2025

⌛ Testing commit e834a2e with merge 73e6c9e...

@bors
Copy link
Collaborator

bors commented Nov 2, 2025

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing 73e6c9e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2025
@bors bors merged commit 73e6c9e into rust-lang:master Nov 2, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bd3ac03 (parent) -> 73e6c9e (this PR)

Test differences

Show 4550 test diffs

4550 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 73e6c9ebd9123154a196300ef58e30ec8928e74e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6575.2s -> 9822.8s (+49.4%)
  2. x86_64-gnu-gcc: 4101.8s -> 3055.5s (-25.5%)
  3. x86_64-gnu-llvm-20: 2892.2s -> 2425.9s (-16.1%)
  4. x86_64-gnu-debug: 7798.0s -> 6736.8s (-13.6%)
  5. dist-aarch64-apple: 5940.5s -> 6648.5s (+11.9%)
  6. x86_64-rust-for-linux: 2984.9s -> 2643.3s (-11.4%)
  7. i686-gnu-nopt-1: 8132.7s -> 7214.7s (-11.3%)
  8. i686-gnu-2: 6284.5s -> 5582.3s (-11.2%)
  9. x86_64-gnu-llvm-20-3: 6331.0s -> 5654.1s (-10.7%)
  10. dist-android: 1388.0s -> 1532.5s (+10.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 2, 2025

Finished benchmarking commit (73e6c9e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.434s -> 472.641s (-0.38%)
Artifact size: 390.87 MiB -> 390.86 MiB (-0.00%)

makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge of rust-lang#147784 - nxsaken:div_exact_return_option, r=d…
8c6ed65 
…tolnay

Return `Option` from `exact_div` and inherit overflow checks

According to rust-lang#139911 (comment), `exact_div` should return `Option::None` if `self % rhs != 0`, panic if `rhs == 0`, and handle overflow conditionally (panic in debug, wrap in release).

rust-lang#147771 should rename `exact_div` to `div_exact`.
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge of rust-lang#147784 - nxsaken:div_exact_return_option, r=d…
df11863 
…tolnay

Return `Option` from `exact_div` and inherit overflow checks

According to rust-lang#139911 (comment), `exact_div` should return `Option::None` if `self % rhs != 0`, panic if `rhs == 0`, and handle overflow conditionally (panic in debug, wrap in release).

rust-lang#147771 should rename `exact_div` to `div_exact`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

@dtolnay dtolnay

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@nxsaken @rustbot @rust-log-analyzer @dtolnay @bors @rust-timer @scottmcm