rustdoc: don't ignore path distance for doc aliases #147701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in HTML/CSS/JS. |
rustbot
added
A-rustdoc-search
This comment has been minimized.
This comment has been minimized.
yotamofek
reviewed
Oct 14, 2025
| */ | ||
| const handleAlias = async(name, alias, dist, index) => { | ||
| const item = nonnull(await this.getRow(alias, false)); | ||
| // space both is an alias for ::, |
Contributor
There was a problem hiding this comment.
I think you meant "a space is both an alias...", but not sure
Contributor
Author
There was a problem hiding this comment.
I believe either is grammatically correct.
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-search-alias-fix
branch
from
853c99a to
0707281
Compare
| 'others': [ | ||
| { 'path': 'alias_path_distance::Foo', 'name': 'baz' }, | ||
| ], | ||
| }, |
Member
There was a problem hiding this comment.
Can you add a fuzzy query test like z and Foo::z so we can confirm it works as well please?
Contributor
Author
There was a problem hiding this comment.
Added, tho used zzzz instead so it wouldn't just match the z in "baz".
This comment has been minimized.
This comment has been minimized.
lolbinarycat
force-pushed
the
rustdoc-search-alias-fix
branch
from
38bcd8e to
3ba87c4
Compare
Collaborator
|
|
GuillaumeGomez
approved these changes
Nov 12, 2025
Member
|
Thanks! @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 13, 2025
Rollup of 7 pull requests Successful merges: - #147701 (rustdoc: don't ignore path distance for doc aliases) - #148735 (Fix ICE caused by invalid spans for shrink_file) - #148839 (fix rtsan_nonblocking_async lint closure ICE) - #148846 (add a test for combining RPIT with explicit tail calls) - #148872 (fix: Do not ICE when missing match arm with ill-formed subty is met) - #148880 (Remove explicit install of `eslint` inside of `tidy`'s Dockerfile) - #148883 (bootstrap: dont require cmake if local-rebuild is enabled) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 13, 2025
Rollup merge of #147701 - lolbinarycat:rustdoc-search-alias-fix, r=GuillaumeGomez rustdoc: don't ignore path distance for doc aliases Ran into a bit of an issue due to the overloading of space (it needs to be a metachar for most searches, but not for doc aliases that have space in them). Not sure if I need to also need to account for other whitespace chars. <img width="1778" height="494" alt="screenshot" src="https://github.com/user-attachments/assets/041e76f1-3b29-4de5-a72b-1431021fb676" /> fixes #146214 r? `@GuillaumeGomez`
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a bit of an issue due to the overloading of space (it needs to be a metachar for most searches, but not for doc aliases that have space in them). Not sure if I need to also need to account for other whitespace chars.
fixes #146214
r? @GuillaumeGomez