-
Notifications
You must be signed in to change notification settings - Fork 13.9k
Do not enable LLD if we don't build host code for targets that opt into it #147698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR modifies If appropriate, please update |
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder if we should eventually transition to
we could also make the LLD config per-target, but that would complicate things
but this seems very reasonable in the meantime, thanks.
@bors r+ rollup=never |
Validated that this change fixes the issue in our Arm64EC validation pipeline: we no longer need to set |
Do not enable LLD if we don't build host code for targets that opt into it Should fix the problem mentioned in #147626 (comment). r? `@jieyouxu`
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry Spurious. |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 33cab8c (parent) -> c6efb90 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c6efb9019b3169fc672248339dbbf13e6a134de3 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (c6efb90): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.834s -> 472.659s (-0.25%) |
Should fix the problem mentioned in #147626 (comment).
r? @jieyouxu