Update t-compiler beta nomination Zulip msg #147527
Conversation
apiraino
force-pushed
the
update-beta-nom-zulip-msg
branch
from
b69b451 to
c340aa0
Compare
|
|
rustbot
added
the
A-meta
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use |
apiraino
force-pushed
the
update-beta-nom-zulip-msg
branch
2 times, most recently
from
e4c6a54 to
dcb6bce
Compare
|
maybe r? @Kobzol (as soon as GitHub starts working again) |
|
We can always change the wording later, the current wording is fine by me. |
|
r? compiler (for someone to approve and merge 🙂 ) |
rustbot
added
the
T-compiler
There was a problem hiding this comment.
Sorry, forgot to send one comment. I was mostly waiting for other people to chime in, but if no one has a comment in a ~day, you can r=me.
@bors delegate+
| @@ -759,6 +765,7 @@ zulip_stream = 474880 # #t-compiler/backports | |||
| topic = "#{number}: beta-nominated" | |||
| message_on_add = "PR #{number} has been **accepted** for **beta** backport." | |||
|
|
|||
| # This is disabled | |||
There was a problem hiding this comment.
I would just remove this if it doesn't do anything. We can always create it again in the future if we redesign how it works.
There was a problem hiding this comment.
Are those really disabled? I don't see anything in the triagebot changes that makes them disabled. So same as @Kobzol comment, let's actually remove them.
8 participants
Sister patch of triagebot#2191
Follow-up to #147263
The triagebot now triggers a different message when a PR is nominated for backport, making it look like more a suggestion to evaluate for the author/reviewers than a mandatory decision for the team to take.
The wording (as per triagebot#2191) is open to suggestions.
Thanks