Make SIMD intrinsics available in const-contexts
#147521
Conversation
|
Some changes occurred to the platform-builtins intrinsics. Make sure the cc @antoyo, @GuillaumeGomez, @bjorn3, @calebzulawski, @programmerjake The Miri subtree was changed cc @rust-lang/miri Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter |
rustbot
added
S-waiting-on-review
|
|
|
Cc @Amanieu |
| let r: f32 = simd_reduce_mul_unordered(x); | ||
| assert_eq!(r, -24_f32); | ||
| let x = f32x4::from_array([1., -2., 3., 4.]); | ||
| let r: f32 = simd_reduce_add_ordered(x, 0.); |
There was a problem hiding this comment.
I know this wasn't there originally, but maybe we should add a test that requires being added in the proper order to return the right result? something like 1.0e20f32 + 1.0 - 1.0e20 - 1.0 == -1.0
There was a problem hiding this comment.
that seems like a nice idea, but I really don't want to add new tests in this PR - this is pretty big by itself anyway
sayantn
force-pushed
the
simd-const-intrinsics
branch
from
8c71ce0 to
48324c2
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #148507) made this pull request unmergeable. Please resolve the merge conflicts. |
sayantn
force-pushed
the
simd-const-intrinsics
branch
from
48324c2 to
76ddb6f
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
7 participants
successor to #146568, this PR actually makes the SIMD intrinsics
const, and modifies the tests to test the const-eval implementationsr? @tgross35 ig (although feel free to reassign, this is not anything targeted really)