Skip to content

Mark PatternTypo suggestion as maybe incorrect #147310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2025
Merged

Mark PatternTypo suggestion as maybe incorrect #147310

merged 1 commit into from
Oct 5, 2025
+1 −1

Conversation

Jules-Bertholet
Copy link
Contributor

Partial fix for #147303.

@rustbot label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. labels Oct 3, 2025
@chenyukang
Copy link
Member

maybe it's better to fix 147303
pattern matching suggestiong: you might have meant to pattern match on the similarly named constant should not report on function arguments positions.

@chenyukang
Copy link
Member

I created a fix for 147303: #147320

@Jules-Bertholet
Copy link
Contributor Author

maybe it's better to fix 147303 pattern matching suggestiong: you might have meant to pattern match on the similarly named constant should not report on function arguments positions.

Yes, that should be done as well, but this suggestion should not be machine-applicable either way.

@chenyukang
Copy link
Member

@bors r=chenyukang

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

📌 Commit d5ba5c1 has been approved by chenyukang

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147310 - Jules-Bertholet:maybe-incorrect-pa…
2a5c6ed 
…ttern-typo, r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for rust-lang#147303.

`@rustbot` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147310 - Jules-Bertholet:maybe-incorrect-pa…
0261572 
…ttern-typo, r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for rust-lang#147303.

``@rustbot`` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147310 - Jules-Bertholet:maybe-incorrect-pa…
5107bd7 
…ttern-typo, r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for rust-lang#147303.

```@rustbot``` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147310 - Jules-Bertholet:maybe-incorrect-pa…
c64c7bf 
…ttern-typo, r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for rust-lang#147303.

````@rustbot```` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
@Zalathar Zalathar mentioned this pull request Oct 5, 2025
Closed
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147359 - Zalathar:rollup-x1pnbjz, r=Zalathar
24bca67 
Rollup of 8 pull requests

Successful merges:

 - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition)
 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147310 (Mark `PatternTypo` suggestion as maybe incorrect)
 - #147320 (Avoid to suggest pattern match on the similarly named in fn signature)
 - #147328 (Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut`)
 - #147337 (Make `fmt::Write` a diagnostic item)
 - #147349 (Improve the advice given by panic_immediate_abort)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147310 - Jules-Bertholet:maybe-incorrect-pattern-typo,…
a634c86 
… r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for #147303.

`@rustbot` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
@bors
Copy link
Collaborator

bors commented Oct 5, 2025

⌛ Testing commit d5ba5c1 with merge a634c86...

@Zalathar Zalathar mentioned this pull request Oct 5, 2025
Merged
@Zalathar
Copy link
Contributor

Zalathar commented Oct 5, 2025

Yielding to enclosing rollup.

@bors retry

bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147363 - Zalathar:rollup-d9kd06g, r=Zalathar
e2c96cc 
Rollup of 7 pull requests

Successful merges:

 - #147288 (compiletest: Make `DirectiveLine` responsible for name/value splitting)
 - #147309 (Add documentation about unwinding to wasm targets)
 - #147310 (Mark `PatternTypo` suggestion as maybe incorrect)
 - #147320 (Avoid to suggest pattern match on the similarly named in fn signature)
 - #147328 (Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut`)
 - #147337 (Make `fmt::Write` a diagnostic item)
 - #147349 (Improve the advice given by panic_immediate_abort)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 620ffe6 into rust-lang:master Oct 5, 2025
10 of 11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 5, 2025
rust-timer added a commit that referenced this pull request Oct 5, 2025
@rust-timer
Unrolled build for #147310
313bbf1 
Rollup merge of #147310 - Jules-Bertholet:maybe-incorrect-pattern-typo, r=chenyukang

Mark `PatternTypo` suggestion as maybe incorrect

Partial fix for #147303.

`@rustbot` label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SparrowLii SparrowLii

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Jules-Bertholet @rustbot @chenyukang @bors @Zalathar @SparrowLii