Make diagnostics clearer for binop-related errors in foreign crates #147281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Oct 4, 2025
jackh726
reviewed
Oct 6, 2025
| | Vec<R> | ||
| | | ||
| note: the foreign item type `Vec<R>` doesn't implement `Add` | ||
| note: `Vec<R>`, which is defined in another crate, doesn't implement `Add` |
There was a problem hiding this comment.
Alternative: two notes. First note, Vec<R> doesn't implement Add. Second note, Vec<R> is defined in another crate.
Advantages: the first note matches non-foreign types (right?), and most people don't need to know about the second note, and the actual problem (the type not being unimplemented) remains syntactically unbroken.
Disadvantage: a little bit more "clutter" with the extra note
jackh726
added
S-waiting-on-author
Fixes redundant language and bad grammar.
rust-cloud-vms
bot
force-pushed
the
clarify-binop-diag
branch
from
fe30357 to
3c6ae00
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jackh726
approved these changes
Oct 29, 2025
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 29, 2025
Rollup of 5 pull requests Successful merges: - #144444 (Contract variable declarations) - #147281 (Make diagnostics clearer for binop-related errors in foreign crates) - #148131 (Skip parameter attribute deduction for MIR with `spread_arg`) - #148224 (bootstrap: `ensure(doc::Std)` no longer opens a browser) - #148226 (Bootstrap update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 29, 2025
Rollup merge of #147281 - fee1-dead-contrib:clarify-binop-diag, r=jackh726 Make diagnostics clearer for binop-related errors in foreign crates Fixes redundant language and bad grammar.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Oct 30, 2025
Rollup of 5 pull requests Successful merges: - rust-lang/rust#144444 (Contract variable declarations) - rust-lang/rust#147281 (Make diagnostics clearer for binop-related errors in foreign crates) - rust-lang/rust#148131 (Skip parameter attribute deduction for MIR with `spread_arg`) - rust-lang/rust#148224 (bootstrap: `ensure(doc::Std)` no longer opens a browser) - rust-lang/rust#148226 (Bootstrap update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redundant language and bad grammar.