Skip to content

Refactor ArrayWindows to use a slice #147204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

Refactor ArrayWindows to use a slice #147204

merged 1 commit into from
Oct 1, 2025
+22 −47

Conversation

@camsteffen
Copy link
Contributor

@camsteffen camsteffen commented Sep 30, 2025 •
edited
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@camsteffen camsteffen changed the title Change ArrayWindows to use a slice Refactor ArrayWindows to use a slice Sep 30, 2025
joboet
joboet reviewed Oct 1, 2025
View reviewed changes
@joboet joboet assigned joboet and unassigned tgross35 Oct 1, 2025
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
hkBst
hkBst reviewed Oct 1, 2025
View reviewed changes
hkBst
hkBst suggested changes Oct 1, 2025
View reviewed changes
Copy link
Member

@hkBst hkBst left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left several suggestions

View changes since this review

@joboet
Copy link
Member

joboet commented Oct 1, 2025

Looks fine to me! r=me once CI has passed.
@bors delegate+

@bors
Copy link
Collaborator

bors commented Oct 1, 2025

✌️ @camsteffen, you can now approve this pull request!

If @joboet told you to "r=me" after making some further change, please make that change, then do @bors r=@joboet

@camsteffen
Copy link
Contributor Author

@bors r=joboet rollup

@bors
Copy link
Collaborator

bors commented Oct 1, 2025

📌 Commit 5ade764 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#147204 - camsteffen:array-windows-ref, r=jo…
9513d67 
…boet

Refactor ArrayWindows to use a slice

[Tracking issue](rust-lang#75027)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#147204 - camsteffen:array-windows-ref, r=jo…
bb6165b 
…boet

Refactor ArrayWindows to use a slice

[Tracking issue](rust-lang#75027)
This was referenced Oct 1, 2025
Closed
Merged
bors added a commit that referenced this pull request Oct 1, 2025
@bors
Auto merge of #147235 - matthiaskrgr:rollup-a0es1x9, r=matthiaskrgr
4da69df 
Rollup of 8 pull requests

Successful merges:

 - #146593 (Allow specifying multiple bounds for same associated item, except in trait objects)
 - #147177 ([DebugInfo] Fix MSVC tuple child creation)
 - #147195 (iter repeat: add tests for new count and last behavior)
 - #147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`)
 - #147204 (Refactor ArrayWindows to use a slice)
 - #147219 (Add proper error handling for closure in impl)
 - #147226 (include `outer_inclusive_binder` of pattern types)
 - #147230 (Fix typo in 'unfulfilled_lint_expectation' to plural)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4b905f9 into rust-lang:master Oct 1, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 1, 2025
rust-timer added a commit that referenced this pull request Oct 1, 2025
@rust-timer
Unrolled build for #147204
c4eba66 
Rollup merge of #147204 - camsteffen:array-windows-ref, r=joboet

Refactor ArrayWindows to use a slice

[Tracking issue](#75027)
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#147204 - camsteffen:array-windows-ref, r=jo…
294e962 
…boet

Refactor ArrayWindows to use a slice

[Tracking issue](rust-lang#75027)
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge of rust-lang#147235 - matthiaskrgr:rollup-a0es1x9, r=matth…
de546aa 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#146593 (Allow specifying multiple bounds for same associated item, except in trait objects)
 - rust-lang#147177 ([DebugInfo] Fix MSVC tuple child creation)
 - rust-lang#147195 (iter repeat: add tests for new count and last behavior)
 - rust-lang#147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`)
 - rust-lang#147204 (Refactor ArrayWindows to use a slice)
 - rust-lang#147219 (Add proper error handling for closure in impl)
 - rust-lang#147226 (include `outer_inclusive_binder` of pattern types)
 - rust-lang#147230 (Fix typo in 'unfulfilled_lint_expectation' to plural)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joboet joboet joboet left review comments

+1 more reviewer

@hkBst hkBst hkBst requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@joboet joboet

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

6 participants

@camsteffen @rustbot @joboet @bors @hkBst @tgross35