-
Notifications
You must be signed in to change notification settings - Fork 14k
Update memchr to 2.7.6 #147029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update memchr to 2.7.6 #147029
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The Miri subtree was changed cc @rust-lang/miri These commits modify the If this was unintentional then you should revert the changes before this PR is merged.
cc @Amanieu, @folkertdev, @sayantn rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
|
If it's not urgent, please file the r-a change upstream, to avoid Cargo.lock conflicts. |
|
For The issue that is fixed in BurntSushi/memchr#188 reminds me of rust-lang/stdarch#1904 where we're also seeing some confusing behavior on |
|
Alright, I'll go through the respective trees for rust-analyzer and stdarch. rust-lang/stdarch#1904 is interesting, I only became aware of it today. I'll keep watching it to see which decision is made, and how it might make the change in memchr 2.7.6 invalid after all. |
memchr 2.7.6 contains a bugfix for aarch64_be
ef0ad97 to
5a3b82b
Compare
|
Sorry it took so long! @bors r+ |
Update memchr to 2.7.6 memchr 2.7.6 contains a bugfix for aarch64_be. Note: I'm not sure about how dependency updates are managed in rust.git. If something should go through another branch or will happen automatically, please let me know.
|
💔 Test failed - checks-actions |
|
@bors retry |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 843f8ce (parent) -> ceb7df7 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ceb7df7e6f17c92c7d49f7e4f02df0e68bc9b38b --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (ceb7df7): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary -1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 483.325s -> 475.105s (-1.70%) |
memchr 2.7.6 contains a bugfix for aarch64_be.
Note: I'm not sure about how dependency updates are managed in rust.git. If something should go through another branch or will happen automatically, please let me know.