Skip to content

Conversation

@neuschaefer
Copy link
Contributor

memchr 2.7.6 contains a bugfix for aarch64_be.

Note: I'm not sure about how dependency updates are managed in rust.git. If something should go through another branch or will happen automatically, please let me know.

@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 25, 2025

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@neuschaefer neuschaefer marked this pull request as draft September 25, 2025 14:24
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025
@lnicola
Copy link
Member

lnicola commented Sep 25, 2025

If it's not urgent, please file the r-a change upstream, to avoid Cargo.lock conflicts.

@folkertdev
Copy link
Contributor

For stdarch updating either here or in the repo is fine, though yeah for Cargo.lock conflicts updating in the repo itself is probably cleaner given that stdarch should only use memchr for tests.

The issue that is fixed in BurntSushi/memchr#188 reminds me of rust-lang/stdarch#1904 where we're also seeing some confusing behavior on aarch64_be, but we're not quite sure yet what the problem is given that currently our tests do pass with what we believe is an incorrect implementation.

@neuschaefer
Copy link
Contributor Author

Alright, I'll go through the respective trees for rust-analyzer and stdarch.

rust-lang/stdarch#1904 is interesting, I only became aware of it today. I'll keep watching it to see which decision is made, and how it might make the change in memchr 2.7.6 invalid after all.

memchr 2.7.6 contains a bugfix for aarch64_be
@neuschaefer neuschaefer marked this pull request as ready for review September 26, 2025 16:02
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2025
@marcoieni
Copy link
Member

Sorry it took so long!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

📌 Commit 5a3b82b has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
bors added a commit that referenced this pull request Nov 7, 2025
Update memchr to 2.7.6

memchr 2.7.6 contains a bugfix for aarch64_be.

Note: I'm not sure about how dependency updates are managed in rust.git. If something should go through another branch or will happen automatically, please let me know.
@bors
Copy link
Collaborator

bors commented Nov 7, 2025

⌛ Testing commit 5a3b82b with merge a3fdaee...

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2025
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2025
@saethlin
Copy link
Member

saethlin commented Nov 7, 2025

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package [email protected]
finished building tool typos
npm WARN deprecated [email protected]: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated [email protected]: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated [email protected]: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated [email protected]: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXl7RCTT/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! 
npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T18_23_01_456Z-debug-0.log

npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T18_22_54_043Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:03:29
  local time: Fri Nov  7 18:23:25 UTC 2025
  network time: Fri, 07 Nov 2025 18:23:25 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

⌛ Testing commit 5a3b82b with merge ceb7df7...

@bors
Copy link
Collaborator

bors commented Nov 8, 2025

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing ceb7df7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2025
@bors bors merged commit ceb7df7 into rust-lang:master Nov 8, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 843f8ce (parent) -> ceb7df7 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ceb7df7e6f17c92c7d49f7e4f02df0e68bc9b38b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 8954.3s -> 5730.7s (-36.0%)
  2. aarch64-apple: 9064.1s -> 7051.7s (-22.2%)
  3. i686-gnu-2: 5099.1s -> 6186.8s (+21.3%)
  4. x86_64-gnu-llvm-21-1: 3226.1s -> 3889.5s (+20.6%)
  5. x86_64-gnu-llvm-20: 2414.1s -> 2881.1s (+19.3%)
  6. aarch64-gnu-debug: 3763.0s -> 4441.5s (+18.0%)
  7. x86_64-rust-for-linux: 2627.3s -> 3030.3s (+15.3%)
  8. arm-android: 5474.2s -> 6301.6s (+15.1%)
  9. dist-aarch64-apple: 7815.0s -> 6727.2s (-13.9%)
  10. dist-ohos-aarch64: 4633.4s -> 4036.8s (-12.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ceb7df7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.3% [-5.3%, -5.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 483.325s -> 475.105s (-1.70%)
Artifact size: 390.81 MiB -> 390.80 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants