Skip to content

Fix infinite recursion in Path::eq with String #146958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

Fix infinite recursion in Path::eq with String #146958

merged 1 commit into from
Sep 25, 2025
+19 −9

Conversation

el-ev
Copy link
Contributor

@el-ev el-ev commented Sep 24, 2025 •
edited by fmease
Loading

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fmease fmease added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 24, 2025
@joboet
Copy link
Member

joboet commented Sep 24, 2025

Oh wow, that's bad...

Could you perhaps update all of these PartialEq implementations to use as_path and as_str? That's indeed a good way of making sure that the call isn't recursive.

@el-ev el-ev force-pushed the fix_path_string_eq_recurse branch from 827dbb7 to 5a4e536 Compare September 24, 2025 13:31
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@el-ev
Copy link
Contributor Author

el-ev commented Sep 24, 2025

Updated other PartialEq implementations and added test coverage.

@joboet
Copy link
Member

joboet commented Sep 24, 2025

Great, thank you!
@bors r+

@bors
Copy link
Collaborator

bors commented Sep 24, 2025

📌 Commit 5a4e536 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2025
@Amanieu Amanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 24, 2025
@cuviper cuviper mentioned this pull request Sep 24, 2025
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 24, 2025
Merged
bors added a commit that referenced this pull request Sep 24, 2025
@bors
Auto merge of #147003 - matthiaskrgr:rollup-b5z9uiz, r=matthiaskrgr
8565a0e 
Rollup of 7 pull requests

Successful merges:

 - #146556 (Fix duration_since panic on unix when std is built with integer overflow checks)
 - #146679 (Clarify Display for error should not include source)
 - #146753 (Improve the pretty print of UnstableFeature clause)
 - #146894 (Improve derive suggestion of const param)
 - #146950 (core: simplify `CStr::default()`)
 - #146958 (Fix infinite recursion in Path::eq with String)
 - #146971 (fix ICE in writeback due to bound regions)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 25, 2025
@bors
Auto merge of #147003 - matthiaskrgr:rollup-b5z9uiz, r=matthiaskrgr
7cfd7d3 
Rollup of 7 pull requests

Successful merges:

 - #146556 (Fix duration_since panic on unix when std is built with integer overflow checks)
 - #146679 (Clarify Display for error should not include source)
 - #146753 (Improve the pretty print of UnstableFeature clause)
 - #146894 (Improve derive suggestion of const param)
 - #146950 (core: simplify `CStr::default()`)
 - #146958 (Fix infinite recursion in Path::eq with String)
 - #146971 (fix ICE in writeback due to bound regions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d10d6bf into rust-lang:master Sep 25, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 25, 2025
rust-timer added a commit that referenced this pull request Sep 25, 2025
@rust-timer
Unrolled build for #146958
6a04b07 
Rollup merge of #146958 - el-ev:fix_path_string_eq_recurse, r=joboet

Fix infinite recursion in Path::eq with String

- Closes [after beta backport] #146940
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Sep 29, 2025
@bors
Auto merge of #147003 - matthiaskrgr:rollup-b5z9uiz, r=matthiaskrgr
af56430 
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#146556 (Fix duration_since panic on unix when std is built with integer overflow checks)
 - rust-lang/rust#146679 (Clarify Display for error should not include source)
 - rust-lang/rust#146753 (Improve the pretty print of UnstableFeature clause)
 - rust-lang/rust#146894 (Improve derive suggestion of const param)
 - rust-lang/rust#146950 (core: simplify `CStr::default()`)
 - rust-lang/rust#146958 (Fix infinite recursion in Path::eq with String)
 - rust-lang/rust#146971 (fix ICE in writeback due to bound regions)

r? `@ghost`
`@rustbot` modify labels: rollup
@cuviper cuviper mentioned this pull request Oct 2, 2025
Open
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 2, 2025
@cuviper cuviper modified the milestones: 1.92.0, 1.91.0 Oct 2, 2025
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
93b26c2 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
12b7c51 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
bors added a commit that referenced this pull request Oct 4, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
4195364 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
e76bb13 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
bors added a commit that referenced this pull request Oct 5, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
c04b0d1 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
bors added a commit that referenced this pull request Oct 6, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
664f2e1 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958
- Make #[link="dl"] an FCW rather than an error #147262

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
8 participants
@el-ev @rustbot @joboet @bors @cuviper @Amanieu @Mark-Simulacrum @fmease