naked_asm: emit a label starting with func_end

[folkertdev]

The cargo asm tool (cargo install cargo-show-asm) pattern matches on such labels to figure out where functions end: normal functions generated by LLVM always do have such a label. We don't guarantee that naked functions emit such a label, but having cargo asm work is convenient.

https://github.com/pacak/cargo-show-asm/blob/be45f67454ad8b634246a7fc69b3c6a963ee93f1/src/asm/statements.rs#L897-L901

To make the label name unique it's suffixed with the name of the current symbol.

r? @Amanieu

[rustbot]

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

[Amanieu]

This is fine but I want to be clear that this is not something that we guarantee, and we reserve the right to change it in the future. It might be better for cargo asm to match on the .size directive instead since that is also always placed at the end of a function.

[folkertdev]

This is fine but I want to be clear that this is not something that we guarantee, and we reserve the right to change it in the future.

Absolutely, I totally agree.

It might be better for cargo asm to match on the .size directive instead since that is also always placed at the end of a function.

Only elf emits .size, while this label match also works for macho, coff and wasm.

[Amanieu]

@bors r+

[bors]

📌 Commit b279428 has been approved by Amanieu

It is now in the queue for this repository.

[bors]

⌛ Testing commit b279428 with merge a62154d...

[rust-log-analyzer]

The job dist-powerpc64le-linux-musl failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
warning: spurious network error (1 try remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
error: failed to get `ident_case` as a dependency of package `darling_core v0.20.11`
    ... which satisfies dependency `darling_core = "=0.20.11"` (locked to 0.20.11) of package `darling v0.20.11`
    ... which satisfies dependency `darling = "^0.20"` (locked to 0.20.11) of package `derive_setters v0.1.8`
    ... which satisfies dependency `derive_setters = "^0.1.6"` (locked to 0.1.8) of package `rustc_errors v0.0.0 (/checkout/compiler/rustc_errors)`
    ... which satisfies path dependency `rustc_errors` (locked to 0.0.0) of package `rustc_codegen_ssa v0.0.0 (/checkout/compiler/rustc_codegen_ssa)`
    ... which satisfies path dependency `rustc_codegen_ssa` (locked to 0.0.0) of package `rustc-main v0.0.0 (/checkout/compiler/rustc)`

Caused by:
  download of id/en/ident_case failed

Caused by:
  failed to download from `https://index.crates.io/id/en/ident_case`

Caused by:
  [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Bootstrap failed while executing `dist --host powerpc64le-unknown-linux-musl --target powerpc64le-unknown-linux-musl`
Build completed unsuccessfully in 0:22:57

[bors]

💔 Test failed - checks-actions

[Amanieu]

@bors retry