Skip to content

Conversation

sysrex
Copy link
Contributor

@sysrex sysrex commented Sep 19, 2025

This PR just changes the wording of the contributing document to remove the deprecated Discord.

Fixes #146756.

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@sysrex sysrex changed the title chore: fixes #146756 chore: removes deprecated discord. Sep 19, 2025
@workingjubilee
Copy link
Member

Thanks.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 19, 2025

📌 Commit 696add0 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 19, 2025
…rkingjubilee

chore: removes deprecated discord.

This PR just changes the wording of the contributing document to remove the deprecated Discord.

Fixes rust-lang#146756.
@Kobzol
Copy link
Member

Kobzol commented Sep 19, 2025

Would be nice to also remove the [rust-discord] link, as it is now unused. But the PR is already in a rollup, so I'd do it only if the rollup fails.

@workingjubilee
Copy link
Member

The rollup is not in-queue yet.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2025
@workingjubilee
Copy link
Member

@sysrex: can you remove line 50 as part of this diff? thanks.

@Kivooeo
Copy link
Member

Kivooeo commented Sep 21, 2025

Why not just replace the link with this server https://discord.gg/rust-lang-community instead of removing it

Or is it because it's not "official"?

@sysrex
Copy link
Contributor Author

sysrex commented Sep 22, 2025

@sysrex: can you remove line 50 as part of this diff? thanks.

absolutely, removed

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 24, 2025
@sysrex
Copy link
Contributor Author

sysrex commented Sep 24, 2025

I've also removed a reference from

//! improved, submit a PR, or chat with us first on [Discord][rust-discord]
.

@workingjubilee
Copy link
Member

@Kivooeo Correct. It is not official and we do not take responsibility for the moderation of it. The purpose of these links is to allow people to more easily discuss the development of Rust with us. Most Rust programmers will never even read these lines of documentation.

@sysrex Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 27, 2025

📌 Commit 8e37f0f has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 28, 2025
…rkingjubilee

chore: removes deprecated discord.

This PR just changes the wording of the contributing document to remove the deprecated Discord.

Fixes rust-lang#146756.
bors added a commit that referenced this pull request Sep 28, 2025
Rollup of 16 pull requests

Successful merges:

 - #142139 (Include additional hashes in src/stage0)
 - #146745 (Clarified error note for usize range matching)
 - #146763 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5))
 - #146788 (chore: removes deprecated discord.)
 - #146942 ([rustdoc] Finish getting rid of usages `write_str`)
 - #147002 (rustdoc-search: stringdex update with more packing)
 - #147061 (fix rebasing cycle heads when not reaching a fixpoint)
 - #147066 (Fix tracking issue number for feature(macro_attr))
 - #147081 (doc: fix a typo in platform-support.md)
 - #147082 (formatting_options: fix alternate docs 0b/0o mixup)
 - #147086 (compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta)
 - #147092 (Do not compute optimized MIR if code does not type-check.)
 - #147093 (redox: switch to colon as path separator)
 - #147095 (Library: Remove remaining private `#[repr]` workarounds)
 - #147098 (Add auto extra-checks in pre-push hook)
 - #147110 (Fix typo)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Sep 28, 2025
Rollup of 14 pull requests

Successful merges:

 - #142139 (Include additional hashes in src/stage0)
 - #146745 (Clarified error note for usize range matching)
 - #146763 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5))
 - #146788 (chore: removes deprecated discord.)
 - #146942 ([rustdoc] Finish getting rid of usages `write_str`)
 - #147061 (fix rebasing cycle heads when not reaching a fixpoint)
 - #147066 (Fix tracking issue number for feature(macro_attr))
 - #147081 (doc: fix a typo in platform-support.md)
 - #147082 (formatting_options: fix alternate docs 0b/0o mixup)
 - #147086 (compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta)
 - #147093 (redox: switch to colon as path separator)
 - #147095 (Library: Remove remaining private `#[repr]` workarounds)
 - #147098 (Add auto extra-checks in pre-push hook)
 - #147110 (Fix typo)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0fd9396 into rust-lang:master Sep 28, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 28, 2025
rust-timer added a commit that referenced this pull request Sep 28, 2025
Rollup merge of #146788 - sysrex:146756/discord_invite, r=workingjubilee

chore: removes deprecated discord.

This PR just changes the wording of the contributing document to remove the deprecated Discord.

Fixes #146756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: discord invite
7 participants