Skip to content

Ignore tests in tests/ui/abi for the GCC backend #146779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2025
Merged

Ignore tests in tests/ui/abi for the GCC backend #146779

merged 1 commit into from
Sep 21, 2025

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 19, 2025 •
edited by rustbot
Loading

Needed for #146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block #146414.

r? @Kobzol

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 19, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

CI passed. :)

@Kobzol
Copy link
Member

Kobzol commented Sep 19, 2025

Hmm, I'd maybe like it more if we just marked all those tests as being LLVM only (or maybe had some "default test directives" per directory?), and then perhaps have a tidy check that ensures that indeed all tests are marked as such, to make the fact that these tests are being skipped more explicit.

That being said, we already have the opt-out for the assembly and codegen tests, so this doesn't seem terribly different from that.

I'd like to hear @jieyouxu's opinion, but otherwise looks fine to me.

@jieyouxu
Copy link
Member

jieyouxu commented Sep 20, 2025 •
edited
Loading

Yes, I would strongly prefer if these are //@ only-backends: llvm or something. I really do not want to land any kind of change, even on a temporary basis, that inscribes special behavior to a particular subdirectory, that's just a footgun waiting to happen.

Actually, we already have //@ ignore-backends don't we? Can you just use those?

@jieyouxu jieyouxu self-assigned this Sep 20, 2025
@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2025
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Sep 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

Sorry, wrong branch push. Updating this PR.

@GuillaumeGomez
Copy link
Member Author

And done!

jieyouxu
jieyouxu approved these changes Sep 21, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review

@jieyouxu
Copy link
Member

@bors r=Kobzol,jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Sep 21, 2025

📌 Commit fd7f8b2 has been approved by Kobzol,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 21, 2025
@bors
Copy link
Collaborator

bors commented Sep 21, 2025

⌛ Testing commit fd7f8b2 with merge 1d23da6...

@bors
Copy link
Collaborator

bors commented Sep 21, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol,jieyouxu
Pushing 1d23da6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2025
@bors bors merged commit 1d23da6 into rust-lang:master Sep 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing dfa2223 (parent) -> 1d23da6 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1d23da6b7304d9e2a2c3dcb1b0aaa709cb9bc4ad --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 7368.0s -> 9325.3s (26.6%)
  2. dist-apple-various: 3917.9s -> 4388.7s (12.0%)
  3. aarch64-msvc-1: 7453.0s -> 6712.6s (-9.9%)
  4. aarch64-apple: 4708.2s -> 5140.5s (9.2%)
  5. dist-aarch64-apple: 6420.2s -> 5888.8s (-8.3%)
  6. x86_64-gnu-aux: 6890.0s -> 6370.5s (-7.5%)
  7. dist-x86_64-netbsd: 4610.9s -> 4952.4s (7.4%)
  8. aarch64-gnu-llvm-20-1: 3477.4s -> 3241.0s (-6.8%)
  9. dist-i586-gnu-i586-i686-musl: 5454.2s -> 5089.6s (-6.7%)
  10. dist-ohos-x86_64: 4217.8s -> 4483.9s (6.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@GuillaumeGomez GuillaumeGomez deleted the gcc-ignore-test_ui_abi branch September 21, 2025 11:09
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1d23da6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.257s -> 470.725s (-0.32%)
Artifact size: 387.89 MiB -> 387.92 MiB (0.01%)

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Sep 24, 2025
@bors @Muscraft
Auto merge of rust-lang#146779 - GuillaumeGomez:gcc-ignore-test_ui_ab…
9cb9722 
…i, r=Kobzol,jieyouxu

Ignore tests in `tests/ui/abi` for the GCC backend

Needed for rust-lang#146414.

Currently we ignore them in the GCC backend and until this situation changes, it'll block rust-lang#146414.

r? `@Kobzol`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Kobzol Kobzol

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GuillaumeGomez @rustbot @rust-log-analyzer @Kobzol @jieyouxu @bors @rust-timer