Simplify default value of download-ci-llvm

[Kobzol]

Just set it to true, rather than having different default values on CI and locally, and then only deny true on our own CI, not elsewhere.

Closes: #146768

r? @jieyouxu

[rustbot]

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

[RalfJung]

Thanks a lot :)

[jieyouxu]

Thanks

View changes since this review

[jieyouxu]

@bors r+ rollup=never

[bors]

📌 Commit 4b75514 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4b75514 with merge bdcf701...

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[bors]

💔 Test failed - checks-actions

[RalfJung]

@bors retry curl: (28) Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds

[bors]

⌛ Testing commit 4b75514 with merge b00998a...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing b00998a to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e4b5219 (parent) -> b00998a (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b00998aaa50a78b1e45fb107a6c0cfd3f1dc44dd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-linux: 6187.1s -> 8911.0s (44.0%)
2. aarch64-apple: 5602.8s -> 5037.6s (-10.1%)
3. dist-aarch64-apple: 6750.9s -> 6079.3s (-9.9%)
4. dist-various-2: 2195.9s -> 2407.0s (9.6%)
5. x86_64-gnu-aux: 6800.4s -> 6307.2s (-7.3%)
6. x86_64-msvc-ext3: 6699.7s -> 6242.0s (-6.8%)
7. dist-apple-various: 3455.3s -> 3659.2s (5.9%)
8. dist-x86_64-apple: 7129.6s -> 7443.7s (4.4%)
9. test-various: 4413.8s -> 4607.2s (4.4%)
10. dist-aarch64-msvc: 5937.0s -> 5683.8s (-4.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b00998a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.018s -> 471.747s (-0.06%)
Artifact size: 389.98 MiB -> 389.94 MiB (-0.01%)