Skip to content

fix: system stats calculation and prevent runtime errors #146715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: system stats calculation and prevent runtime errors #146715

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5ea51b
fix: system stats calculation and prevent runtime errors
mdqst Sep 18, 2025
f8e0b47
Update cpu-usage-over-time.py
mdqst Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/ci/cpu-usage-over-time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ def __init__(self):
data = file.readline().split()
if data[0] != "cpu":
raise Exception('did not start with "cpu"')
if len(data) < 11:
raise Exception("Unexpected /proc/stat format")
self.user = int(data[1])
self.nice = int(data[2])
self.system = int(data[3])
Expand Down Expand Up @@ -82,11 +84,11 @@ def idle_since(self, prev):
+ guest
+ guest_nice
)
return float(idle) / float(total) * 100
return float(idle) / total * 100 if total != 0 else 0.0

elif sys.platform == "win32":
from ctypes.wintypes import DWORD
from ctypes import Structure, windll, WinError, GetLastError, byref
from ctypes import Structure, windll, WinError, byref

class FILETIME(Structure):
_fields_ = [
Expand All @@ -104,7 +106,8 @@ def __init__(self):
byref(user),
)

assert success, WinError(GetLastError())[1]
if not success:
raise WinError()

self.idle = (idle.dwHighDateTime << 32) | idle.dwLowDateTime
self.kernel = (kernel.dwHighDateTime << 32) | kernel.dwLowDateTime
Expand All @@ -114,7 +117,7 @@ def idle_since(self, prev):
idle = self.idle - prev.idle
user = self.user - prev.user
kernel = self.kernel - prev.kernel
return float(idle) / float(user + kernel) * 100
return float(idle) / float(user + kernel - idle) * 100 if user + kernel - idle != 0 else 0.0

elif sys.platform == "darwin":
from ctypes import *
Expand Down Expand Up @@ -159,7 +162,8 @@ def idle_since(self, prev):
system = self.system - prev.system
idle = self.idle - prev.idle
nice = self.nice - prev.nice
return float(idle) / float(user + system + idle + nice) * 100.0
total = user + system + idle + nice
return float(idle) / total * 100 if total != 0 else 0.0

else:
print("unknown platform", sys.platform)
Expand All @@ -170,7 +174,7 @@ def idle_since(self, prev):
while True:
time.sleep(1)
next_state = State()
now = datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None).isoformat()
now = datetime.datetime.now(datetime.timezone.utc).isoformat()
idle = next_state.idle_since(cur_state)
print("%s,%s" % (now, idle))
sys.stdout.flush()
Expand Down
Loading