Skip to content

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Sep 17, 2025

I upstreamed a few of our rust-lang/Enzyme patches, so I could drop them in our fork.

r? compiler

@rustbot rustbot added F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

⚠️ Warning ⚠️

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me when CI passes

View changes since this review

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Sep 18, 2025

Soon we'll hopefully test this module in CI.
@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Sep 18, 2025

📌 Commit ef90d22 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025
@bors
Copy link
Collaborator

bors commented Sep 18, 2025

⌛ Testing commit ef90d22 with merge 32e3d9f...

@bors
Copy link
Collaborator

bors commented Sep 18, 2025

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 32e3d9f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2025
@bors bors merged commit 32e3d9f into rust-lang:master Sep 18, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 18, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 97a987f (parent) -> 32e3d9f (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 32e3d9f59bae4bcf436bc1e28723c696d2c75b11 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-powerpc64le-linux-musl: 5827.0s -> 5258.2s (-9.8%)
  2. test-various: 4456.3s -> 4828.7s (8.4%)
  3. x86_64-gnu-aux: 6379.0s -> 6892.3s (8.0%)
  4. dist-armv7-linux: 5505.0s -> 5073.7s (-7.8%)
  5. dist-powerpc-linux: 4994.3s -> 5362.3s (7.4%)
  6. dist-aarch64-msvc: 6103.4s -> 5716.4s (-6.3%)
  7. aarch64-apple: 5812.6s -> 5458.3s (-6.1%)
  8. dist-various-1: 3764.5s -> 3978.1s (5.7%)
  9. dist-x86_64-windows-gnullvm: 5138.9s -> 4854.9s (-5.5%)
  10. dist-s390x-linux: 4968.1s -> 5230.9s (5.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (32e3d9f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 8.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
8.0% [8.0%, 8.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 8.0% [8.0%, 8.0%] 1

Cycles

Results (secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
5.1% [5.1%, 5.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.46s -> 471.73s (0.06%)
Artifact size: 387.92 MiB -> 387.92 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

F-autodiff `#![feature(autodiff)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants