Skip to content

ci: x86_64-gnu-tools: Add --test-args regression test #146606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2025
Merged

ci: x86_64-gnu-tools: Add --test-args regression test #146606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,10 @@ cat /tmp/toolstate/toolstates.json
python3 "$X_PY" test --stage 2 check-tools
python3 "$X_PY" test --stage 2 src/tools/clippy
python3 "$X_PY" test --stage 2 src/tools/rustfmt

# The below is a regression test for https://github.com/rust-lang/rust/pull/146501#issuecomment-3292608398.
# The bug caused 0 tests to run. By grepping on that 1 test is run we prevent regressing.
# Any test can be used. We arbitrarily chose `tests/ui/lint/unused/unused-result.rs`.
python3 "$X_PY" test tests/ui --test-args tests/ui/lint/unused/unused-result.rs --force-rerun |
grep --fixed-strings 'test result: ok. 1 passed; 0 failed; 0 ignored;' ||
( echo "ERROR: --test-args functionality is broken" && exit 1 )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I was thinking of more of a unit test directly in compiletest, but I think this seems OK too.

Loading