compiletest: Enable new-output-capture by default #146574
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-testsuite
|
I mentioned at #146119 (comment) that I was thinking of waiting a week, but since then the version bump has landed (#146507), so I figure we might as well go ahead now. |
jieyouxu
approved these changes
Sep 15, 2025
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 9 pull requests Successful merges: - #145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - #145960 (Split `FnCtxt::report_args_error` into subfunctions) - #146402 (interpret: fix overlapping aggregate initialization) - #146466 (llvm-wrapper: other cleanup) - #146574 (compiletest: Enable new-output-capture by default) - #146599 (replace some `#[const_trait]` with `const trait`) - #146601 (compiletest: Make `./x test --test-args ...` work again) - #146608 (improve internal bootstrap docs) - #146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup merge of #146574 - Zalathar:capture, r=jieyouxu compiletest: Enable new-output-capture by default The new output-capture implementation was added in #146119, but was disabled by default and required opt-in. Since then, I haven't encountered any problems in my own testing/usage, and I haven't heard any problem reports from other contributors who might have opted in. It's unlikely that more opt-in testing will help, so the next step is to enable new-output-capture by default and see if anyone complains. (Hopefully nobody!) If needed, the new default can be overridden (for now) by setting environment variable `COMPILETEST_NEW_OUTPUT_CAPTURE=off`. Please file an issue (or let me know) if anyone finds a reason to do this. r? jieyouxu
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 17, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#145095 (Migrate `UnsizedConstParamTy` to unstable impl of `ConstParamTy_`) - rust-lang/rust#145960 (Split `FnCtxt::report_args_error` into subfunctions) - rust-lang/rust#146402 (interpret: fix overlapping aggregate initialization) - rust-lang/rust#146466 (llvm-wrapper: other cleanup) - rust-lang/rust#146574 (compiletest: Enable new-output-capture by default) - rust-lang/rust#146599 (replace some `#[const_trait]` with `const trait`) - rust-lang/rust#146601 (compiletest: Make `./x test --test-args ...` work again) - rust-lang/rust#146608 (improve internal bootstrap docs) - rust-lang/rust#146609 (bootstrap: lower verbosity of cargo to one less than bootstrap's) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 29, 2025
compiletest: Remove old-output-capture and become a stage0 bootstrap tool The new compiletest output-capture system became the default in rust-lang#146574, and no problems have been reported since. This PR therefore removes the old output-capture implementation from compiletest, and adjusts bootstrap to always build and test compiletest as a stage0 bootstrap tool. In other words, compiletest no longer relies on any unstable features (such as `libtest` or `internal_output_capture`), and is now written entirely in stable Rust! The compiletest self-tests still need access to an in-tree rustc, in order to obtain information via `rustc --print`, so we interpret `--stage` as indicating the stage of that secondary compiler, but always use the stage0 compiler to build compiletest itself. r? Kobzol
rust-timer
added a commit
that referenced
this pull request
Sep 29, 2025
Rollup merge of #146929 - Zalathar:capture, r=Kobzol,jieyouxu compiletest: Remove old-output-capture and become a stage0 bootstrap tool The new compiletest output-capture system became the default in #146574, and no problems have been reported since. This PR therefore removes the old output-capture implementation from compiletest, and adjusts bootstrap to always build and test compiletest as a stage0 bootstrap tool. In other words, compiletest no longer relies on any unstable features (such as `libtest` or `internal_output_capture`), and is now written entirely in stable Rust! The compiletest self-tests still need access to an in-tree rustc, in order to obtain information via `rustc --print`, so we interpret `--stage` as indicating the stage of that secondary compiler, but always use the stage0 compiler to build compiletest itself. r? Kobzol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new output-capture implementation was added in #146119, but was disabled by default and required opt-in.
Since then, I haven't encountered any problems in my own testing/usage, and I haven't heard any problem reports from other contributors who might have opted in.
It's unlikely that more opt-in testing will help, so the next step is to enable new-output-capture by default and see if anyone complains. (Hopefully nobody!)
If needed, the new default can be overridden (for now) by setting environment variable
COMPILETEST_NEW_OUTPUT_CAPTURE=off. Please file an issue (or let me know) if anyone finds a reason to do this.r? jieyouxu