Improve core::ascii coverage
#146474
Merged
Improve core::ascii coverage
#146474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
|
|
🙏 I know that I reviewed a couple of your PRs opportunistically, but I am still working on clearing my queue and even evaluating whether a PR is simple enough to "just glance at and r+" can be a tad costly. r? libs |
Noratrieb
reviewed
Sep 12, 2025
Noratrieb
approved these changes
Sep 12, 2025
pvdrz
force-pushed
the
pvdrz/improve-ascii-coverage
branch
from
b79744c to
e652f97
Compare
|
@Noratrieb this is ready again |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 16, 2025
Rollup of 5 pull requests Successful merges: - #146442 (Display ?Sized, const, and lifetime parameters in trait item suggestions across a crate boundary) - #146474 (Improve `core::ascii` coverage) - #146605 (Bump rustfix 0.8.1 -> 0.8.7) - #146611 (bootstrap: emit hint if a config key is used in the wrong section) - #146618 (Do not run ui test if options specific to LLVM are used when another codegen backend is used) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup merge of #146474 - ferrocene:pvdrz/improve-ascii-coverage, r=Noratrieb Improve `core::ascii` coverage This PR improves the `core::ascii` coverage by adding a new test to `coretests` r? `@workingjubilee`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
core::asciicoverage by adding a new test tocoretestsr? @workingjubilee