-
Notifications
You must be signed in to change notification settings - Fork 13.8k
bootstrap: Build jemalloc for LoongArch with support for 16K pages #146444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
By default, jemalloc is configured with a 4K page size. If the host’s page size is larger than this, it will crash at runtime. This patch raises the page size to 16K.
r? @clubby789 rustbot has assigned @clubby789. Use |
Are you able to add a test for this? |
It doesn't seem straightforward to add a proper test case for this in rustc, which may also explain why the similar AArch64 patch didn't include one. One of the goals of this patch is to fix the issue that prevents miri from working on LoongArch, where the default jemalloc page size fails to meet the requirements and causes an assertion failure: os_page = os_page_detect();
if (os_page > PAGE) {
malloc_write("<jemalloc>: Unsupported system page size\n");
if (opt_abort) {
abort();
}
return true;
} |
@bors r+ I think proceeding without a test is fine. Without tier 1 support/native runners I wouldn't expect testing this to be particularly easy. |
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5c11fb8 (parent) -> 4ba1cf9 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4ba1cf9ade4c8e2fa10676a50ee34594eb161837 --output-dir test-dashboard And then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Finished benchmarking commit (4ba1cf9): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.518s -> 468.868s (0.07%) |
By default, jemalloc is configured with a 4K page size. If the host’s page size is larger than this, it will crash at runtime. This patch raises the page size to 16K.