Rollup of 7 pull requests #146333
Merged
Rollup of 7 pull requests #146333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-date contributing: clarify when to update a branch vs avoid during review
…preserve local style
dates: refresh infra/tooling date annotations to Aug 2025
dates: refresh query-system date annotations to 2025-08 (preserve style)
…s-traits dates: refresh type system & traits date annotations to Aug/2025
…-tests dates: refresh diagnostics/ and tests/ annotated dates to August 2025
stabilization_guide: fix macro name and syntax in gating example
This updates mdbook to 0.4.52, which includes a number of fixes and enhancements since 0.4.48. Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0452
Update mdbook
…ep-2025-08-types-traits Revert "dates: refresh type system & traits date annotations to Aug/2025"
…ep-2025-08-queries Revert "dates: refresh query-system date annotations to 2025-08 (preserve style)"
…ep-2025-08-infra Revert "dates: refresh infra/tooling date annotations to Aug 2025"
…ep-2025-08-diag-tests Revert "dates: refresh diagnostics/ and tests/ annotated dates to August 2025"
Rustc pull update
…lear clarify typo pr guidance
…efid, r=lcnr Migrate more things in the new solver to specific `DefId`s Continuation of rust-lang#145377. I migrated the rest of the types, except aliases. Aliases are problematic because opaques and associated types share the same type in the new solver. `@jackh726,` `@lcnr,` `@ShoyuVanilla` I'd like to hear ideas here. Anyway, even if we do nothing with them we already got a substantial improvement. r? types
GVN: Ensure indirect is first projection in try_as_place. I haven't found any report for this bug on existing code, but managed to trigger it with rust-lang#143333
…lize-docs, r=jhpratt docs(std): add error docs for path canonicalize This PR adds the missing error documentation for both [Path.canonicalize](https://doc.rust-lang.org/std/path/struct.Path.html#method.canonicalize) and [PathBuf.canonicalize](https://doc.rust-lang.org/std/path/struct.PathBuf.html#method.canonicalize) methods. Since both methods are wappers around [fs::canonicalize](https://doc.rust-lang.org/std/fs/fn.canonicalize.html), the error doc is copied directly from that function. This makes it faster to find what errors might arise when calling `path.canonicalize` or `path_buf.canonicalize` in the editor itself without needing to drill down to the `fs::canonicalzie` docs.
Allow static regions in `type_name`. Fixes rust-lang#146249. r? `@lcnr`
…ps-2, r=lcnr Some `rustc_middle` cleanups Minor improvements I found while looking through this code. r? `@BoxyUwU`
Fix typo in default.rs This sentence currently reads: > Rust implements `Default` for various primitives types. I think it should just be "primitive types".
rustc-dev-guide subtree update Subtree update of `rustc-dev-guide` to rust-lang/rustc-dev-guide@d03ffd4. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
rustbot
added
A-rustc-dev-guide
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 68baa87ba6 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 68baa87 (parent) -> a78f9aa (this PR) Test differencesShow 60 test diffs60 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a78f9aa87fa828ad4a5c11f1e3b93e94d9352ad6 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a78f9aa): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 3.2%, secondary 5.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 468.245s -> 466.425s (-0.39%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
DefIds #146111 (Migrate more things in the new solver to specificDefIds)type_name. #146310 (Allow static regions intype_name.)rustc_middlecleanups #146313 (Somerustc_middlecleanups)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup