tidy: check that error messages don't start with a capitalized letter #146171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
A-tidy
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
push-wovnxxwltsun
branch
2 times, most recently
from
0b8a1dd to
4d08e6e
Compare
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_ssa |
|
@rustbot ready |
pietroalbini
removed
the
S-blocked
WaffleLapkin
requested changes
Sep 7, 2025
Comment on lines
+61
to
+62
| &mut |ent, contents| { | ||
| check_lowercase(ent.path().to_str().unwrap(), contents, bad); | ||
| }, |
There was a problem hiding this comment.
q: doesn't this get called for dirs? if so, you should probably add a check for them here.
There was a problem hiding this comment.
it is not called on dirs because we filter out dirs right before that:
|path, is_dir| filter_dirs(path) || (!is_dir && filter_fluent(path)),
rustbot
added
S-waiting-on-author
scrabsha
force-pushed
the
push-wovnxxwltsun
branch
from
4d08e6e to
b152974
Compare
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step after #146112. The implementation of this is better than the hacks I wrote earlier, which allowed me to discover more capitalized error messages.
@rustbot blocked
r? @WaffleLapkin