Skip to content

fix: offline rustdoc html missing favicon #146170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2025
Merged

fix: offline rustdoc html missing favicon #146170

merged 1 commit into from
Sep 7, 2025

Conversation

kumarUjjawal
Copy link
Contributor

@kumarUjjawal kumarUjjawal commented Sep 3, 2025 •
edited by rustbot
Loading

As discussed in the #146149 the doc was missing the favicon icon when build locally and viewed on a browser. I changed the relative path and also now we explicitly copy both SVG and PNG.

Screenshot 2025-09-03 at 11 57 46 PM

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 3, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit f3650b8 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2025
Merged
bors added a commit that referenced this pull request Sep 7, 2025
@bors
Auto merge of #146304 - matthiaskrgr:rollup-69hs07h, r=matthiaskrgr
12eb345 
Rollup of 4 pull requests

Successful merges:

 - #146170 (fix: offline rustdoc html missing favicon)
 - #146209 (Misc LTO cleanups)
 - #146269 (feat(std): emulate flock for solaris via fcntl)
 - #146297 (Introduce PlaceContext::may_observe_address.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cb64a77 into rust-lang:master Sep 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
rust-timer added a commit that referenced this pull request Sep 7, 2025
@rust-timer
Unrolled build for #146170
d3b4e2a 
Rollup merge of #146170 - kumarUjjawal:master, r=Mark-Simulacrum

fix: offline rustdoc html missing favicon

As discussed in the #146149 the doc was missing the favicon icon when build locally and viewed on a browser. I changed the relative path and also now we explicitly copy both SVG and PNG.

<img width="1132" height="425" alt="Screenshot 2025-09-03 at 11 57 46 PM" src="https://github.com/user-attachments/assets/062cbb08-04ec-4d88-a43a-710fb6190f82" />
@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kumarUjjawal @rustbot @Mark-Simulacrum @bors