Test `rustc-dev` in `distcheck` #146124

Kobzol · 2025-09-02T15:04:28Z

Adds a new distcheck test component.

Fixes: #138646

r? @jieyouxu

try-job: x86_64-gnu-distcheck

Kobzol · 2025-09-02T15:04:37Z

@bors try

Test `rustc-dev` in `distcheck` try-job: x86_64-gnu-distcheck

rust-bors · 2025-09-02T17:07:34Z

💔 Test for 7282a27 failed: CI. Failed jobs:

try - x86_64-gnu-distcheck (web logs, extended logs)

RalfJung · 2025-09-02T20:21:24Z

src/bootstrap/src/core/build_steps/test.rs

+    command(&builder.initial_cargo)
+        .arg("metadata")
+        .arg("--manifest-path")
+        .arg("rustc-dev/lib/rustlib/rustc-src/rust/compiler/rustc_ast/Cargo.toml")


Using rustc/Cargo.toml would load a crate that depends on ~all the other crates, which might give better test coverage.

bors · 2025-09-03T00:01:01Z

☔ The latest upstream changes (presumably #146076) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-09-03T00:48:30Z

Hm, Ralf's suggestion with using rustc-the-crate makes sense to me.
@rustbot author

rustbot · 2025-09-03T07:34:16Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Kobzol · 2025-09-03T07:34:21Z

@bors try

Test `rustc-dev` in `distcheck` try-job: x86_64-gnu-distcheck

rust-bors · 2025-09-03T09:55:10Z

☀️ Try build successful (CI)
Build commit: 3960ea7 (3960ea7b9bd5193577e58daf140d0e9534ce85aa, parent: 51ff895062ba60a7cba53f57af928c3fb7b0f2f4)

Kobzol · 2025-09-03T09:56:29Z

Switched to the rustc crate.

@rustbot ready

jieyouxu

Thanks, the changes themselves look good to me, just a tiny drive-by nit on pre-existing distcheck dir names because they made it even more confusing...

View changes since this review

jieyouxu · 2025-09-03T12:52:09Z

src/bootstrap/src/core/build_steps/test.rs

-            .current_dir(&src_dir)
-            .run(builder);
-    }
+        distcheck_plain_source_tarball(builder, &root_dir.join("distcheck-plain-src"));


Suggestion: could you add a comment that this is rustc-src while the one below is rust-src? And even maybe change the dir name here to distcheck-rustc-src? I know this is historical, but rustc-src and rust-src are two incredible names that are totally not confusing.

Or maybe just change their dir names to match the actual dist component name, because I find that diverging here introduces even more *-srcs, and it really confused me. As in, distcheck-plain-src checks rustc-src, and distcheck-src checks rust-src...

jieyouxu · 2025-09-03T13:06:32Z

Feel free to r=me after the dir name nit
@rustbot author

Kobzol · 2025-09-03T13:30:55Z

@bors r=jieyouxu rollup

bors · 2025-09-03T13:30:57Z

📌 Commit fe90610 has been approved by jieyouxu

It is now in the queue for this repository.

Test `rustc-dev` in `distcheck` Adds a new `distcheck` test component. Fixes: rust-lang#138646 r? `@jieyouxu` try-job: x86_64-gnu-distcheck

Rollup of 24 pull requests Successful merges: - #140459 (Add `read_buf` equivalents for positioned reads) - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145342 (fix drop scope for `super let` bindings within `if let`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - #145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146112 (don't uppercase error messages) - #146120 (Correct typo in `rustc_errors` comment) - #146124 (Test `rustc-dev` in `distcheck`) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - #146150 (fix(rustdoc): match rustc `--emit` precedence ) - #146155 (Make bootstrap self test parallel) - #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - #146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #146124 - Kobzol:distcheck-ext, r=jieyouxu Test `rustc-dev` in `distcheck` Adds a new `distcheck` test component. Fixes: #138646 r? ``@jieyouxu`` try-job: x86_64-gnu-distcheck

Rollup of 24 pull requests Successful merges: - rust-lang/rust#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang/rust#143725 (core: add Peekable::next_if_map) - rust-lang/rust#145209 (Stabilize `path_add_extension`) - rust-lang/rust#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang/rust#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang/rust#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang/rust#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang/rust#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang/rust#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang/rust#146054 (add `#[must_use]` to `array::repeat`) - rust-lang/rust#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang/rust#146112 (don't uppercase error messages) - rust-lang/rust#146120 (Correct typo in `rustc_errors` comment) - rust-lang/rust#146124 (Test `rustc-dev` in `distcheck`) - rust-lang/rust#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang/rust#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang/rust#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang/rust#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang/rust#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang/rust#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang/rust#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang/rust#146155 (Make bootstrap self test parallel) - rust-lang/rust#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang/rust#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 24 pull requests Successful merges: - rust-lang#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang#143725 (core: add Peekable::next_if_map) - rust-lang#145209 (Stabilize `path_add_extension`) - rust-lang#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang#146054 (add `#[must_use]` to `array::repeat`) - rust-lang#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang#146112 (don't uppercase error messages) - rust-lang#146120 (Correct typo in `rustc_errors` comment) - rust-lang#146124 (Test `rustc-dev` in `distcheck`) - rust-lang#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang#146155 (Make bootstrap self test parallel) - rust-lang#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Sep 2, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 2, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 2, 2025

Auto merge of #146124 - Kobzol:distcheck-ext, r=<try>

7282a27

Test `rustc-dev` in `distcheck` try-job: x86_64-gnu-distcheck

Kobzol mentioned this pull request Sep 2, 2025

test rustc-dev dist component on CI #138646

Closed

This comment has been minimized.

Sign in to view

Kobzol force-pushed the distcheck-ext branch from fefaa85 to 880f262 Compare September 2, 2025 15:43

This comment has been minimized.

Sign in to view

RalfJung reviewed Sep 2, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025

Split distcheck logic into functions

f19c33e

Kobzol force-pushed the distcheck-ext branch from 880f262 to 0f4c806 Compare September 3, 2025 07:34

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 3, 2025

Auto merge of #146124 - Kobzol:distcheck-ext, r=<try>

3960ea7

Test `rustc-dev` in `distcheck` try-job: x86_64-gnu-distcheck

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2025

jieyouxu approved these changes Sep 3, 2025

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 3, 2025

Check rustc-dev in distcheck

fe90610

Kobzol force-pushed the distcheck-ext branch from 0f4c806 to fe90610 Compare September 3, 2025 13:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2025

Zalathar mentioned this pull request Sep 4, 2025

Rollup of 24 pull requests #146185

Merged

bors merged commit 1456b67 into rust-lang:master Sep 4, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Sep 4, 2025

Kobzol deleted the distcheck-ext branch September 4, 2025 06:10

Test rustc-dev in distcheck #146124

Test rustc-dev in distcheck #146124

Uh oh!

Conversation

Kobzol commented Sep 2, 2025

Uh oh!

Kobzol commented Sep 2, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 2, 2025

Uh oh!

This comment has been minimized.

RalfJung Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Sep 3, 2025

Uh oh!

jieyouxu commented Sep 3, 2025

Uh oh!

rustbot commented Sep 3, 2025

Uh oh!

Kobzol commented Sep 3, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Sep 3, 2025

Uh oh!

Kobzol commented Sep 3, 2025

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Sep 3, 2025

Uh oh!

Kobzol commented Sep 3, 2025

Uh oh!

bors commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

Test `rustc-dev` in `distcheck` #146124

Test `rustc-dev` in `distcheck` #146124

jieyouxu left a comment •

edited by rustbot

Loading

jieyouxu Sep 3, 2025 •

edited

Loading