-
Notifications
You must be signed in to change notification settings - Fork 14k
Stabilize vec_deque_pop_if
#145992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GrigorenkoPV
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
GrigorenkoPV:stabilize/vec_deque_pop_if
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stabilize vec_deque_pop_if
#145992
GrigorenkoPV
wants to merge
1
commit into
rust-lang:master
from
GrigorenkoPV:stabilize/vec_deque_pop_if
+4
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
☔ The latest upstream changes (presumably #148014) made this pull request unmergeable. Please resolve the merge conflicts. |
70290aa to
2f4813f
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r+ |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 7, 2025
…op_if, r=Amanieu Stabilize `vec_deque_pop_if` Tracking issue: rust-lang#135889 Closes rust-lang#135889 Also fixes a typo mentioned in rust-lang#135889 (comment) FCP: rust-lang#135889 (comment) `@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp r? t-libs-api
bors
added a commit
that referenced
this pull request
Nov 7, 2025
Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #135889
Closes #135889
Also fixes a typo mentioned in #135889 (comment)
FCP: #135889 (comment)
@rustbot label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api