Skip to content

Conversation

@GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Aug 29, 2025

Tracking issue: #135889
Closes #135889
Also fixes a typo mentioned in #135889 (comment)

FCP: #135889 (comment)

@rustbot label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp

r? t-libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 29, 2025
@rustbot rustbot added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2025
@bors
Copy link
Collaborator

bors commented Oct 23, 2025

☔ The latest upstream changes (presumably #148014) made this pull request unmergeable. Please resolve the merge conflicts.

@GrigorenkoPV GrigorenkoPV force-pushed the stabilize/vec_deque_pop_if branch from 70290aa to 2f4813f Compare October 23, 2025 20:44
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GrigorenkoPV
Copy link
Contributor Author

@rustbot ready
@rustbot label -needs-fcp -S-waiting-on-fcp

@rustbot rustbot removed needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. labels Nov 6, 2025
@Amanieu
Copy link
Member

Amanieu commented Nov 6, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit 2f4813f has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 7, 2025
…op_if, r=Amanieu

Stabilize `vec_deque_pop_if`

Tracking issue: rust-lang#135889
Closes rust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)

FCP: rust-lang#135889 (comment)

`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp

r? t-libs-api
bors added a commit that referenced this pull request Nov 7, 2025
Rollup of 12 pull requests

Successful merges:

 - #145768 (Offload device)
 - #145992 (Stabilize `vec_deque_pop_if`)
 - #147416 (Early return if span is from expansion so we dont get empty span and ice later on)
 - #147808 (btree: cleanup difference, intersection, is_subset)
 - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`)
 - #148559 (Add typo suggestion for a misspelt Cargo environment variable)
 - #148567 (Fix incorrect precedence caused by range expression)
 - #148570 (Fix mismatched brackets in generated .dir-locals.el)
 - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md)
 - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`)
 - #148603 (Backport 1.91.1 relnotes to main)
 - #148609 (Sync str::rsplit_once example with str::split_once)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for VecDeque::pop_front_if & VecDeque::pop_back_if

4 participants