[beta] Clippy beta backport #144742
Closed
[beta] Clippy beta backport #144742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang/rust-clippy#15151 See also https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/uninlined_format_args.20is.20contentious/ changelog: Move [`uninlined_format_args`] to `pedantic`
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
This comment has been minimized.
This comment has been minimized.
This was referenced Jul 31, 2025
This comment has been minimized.
This comment has been minimized.
If there are more than one dereference (there is one corresponding matched with a borrow in any case), consider that the argument might point to a place expression, which is the safest choice. Also, use an appropriate number of dereferences in suggestions involving arguments using themselves multiple dereferences. Fixes rust-lang/rust-clippy#15166 changelog: [`swap_with_temporary`]: fix false positive leading to different semantics being suggested, and use the right number of dereferences in suggestion r? y21 <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [beta-nomination](rust-lang/rust-clippy#15172 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
…comparisons (rust-lang#14646)" This reverts commit 551870d, reversing changes made to 3927a61.
flip1995
force-pushed
the
clippy-beta-backport
branch
from
e96eaca to
7e4ec38
Compare
|
|
|
@bors r+ rollup=never |
bors
added
S-waiting-on-bors
|
Bumping the p on this beta backport since this close to stable. |
Merged
|
Included in #144800. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum
Backporting
uninlined_format_argstopedanticrust-clippy#15287Reverting buggy lint extensions:
manual_is_variant_and lintto check for boolean map comparisons rust-clippy#14646return_and_then: only lint returning expressions rust-clippy#14783The two backports are for things that were changed in 1.88 already, but we don't want to wait another cycle to fix the issues that originated from those changes.
The two reverts are for lints that started triggering on more cases in 1.89. The proper fixes for them rust-lang/rust-clippy#15206 and rust-lang/rust-clippy#15115 respectively were too big to include in a beta backport and should go through the nightly cycle. To still fix the issues, the extensions are reverted on
betaand will be reintroduced together with their fixes in the next beta 1.90.