Account for bare tuples and `Pin` methods in field searching logic #144649

estebank · 2025-07-29T18:39:53Z

When looking for the field names and types of a given type, account for tuples. This allows suggestions for incorrectly nested field accesses and field name typos to trigger as intended. Previously these suggestions only worked on ty::Adt, including tuple structs which are no different to tuples, so they should behave the same in suggestions.

When suggesting field access which would encounter a method not found, do not suggest pinning when those methods are on impl Pin itself.

error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope
  --> $DIR/missing-field-access.rs:11:15
   |
LL |     let x = f.get_ref();
   |               ^^^^^^^ method not found in `(BufReader<File>,)`
   |
help: one of the expressions' fields has a method of the same name
   |
LL |     let x = f.0.get_ref();
   |               ++

instead of

error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope
  --> $DIR/missing-field-access.rs:11:15
   |
LL |     let x = f.get_ref();
   |               ^^^^^^^ method not found in `(BufReader<File>,)`
   |
help: consider pinning the expression
   |
LL ~     let mut pinned = std::pin::pin!(f);
LL ~     let x = pinned.as_ref().get_ref();
   |

Fix #144602.

rustbot · 2025-07-29T18:39:58Z

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_hir_typeck/src/expr.rs

tests/ui/consts/issue-19244-1.stderr

compiler/rustc_hir_typeck/src/method/suggest.rs

rustbot · 2025-07-30T16:21:48Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

bors · 2025-08-06T19:37:46Z

☔ The latest upstream changes (presumably #145003) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_hir_typeck/src/method/suggest.rs

lcnr

final nits, then r=me

compiler/rustc_hir_typeck/src/expr.rs

When looking for the field names and types of a given type, account for tuples. This allows suggestions for incorrectly nested field accesses and field name typos to trigger as intended. Previously these suggestions only worked on `ty::Adt`, including tuple structs which are no different to tuples, so they should behave the same in suggestions. ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.rs:11:15 | LL | let x = f.get_ref(); | ^^^^^^^ method not found in `(BufReader<File>,)` | help: one of the expressions' fields has a method of the same name | LL | let x = f.0.get_ref(); | ++ ```

When suggesting field access which would encounter a method not found, do not suggest pinning when those methods are on `impl Pin` itself. ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.rs:11:15 | LL | let x = f.get_ref(); | ^^^^^^^ method not found in `(BufReader<File>,)` | help: one of the expressions' fields has a method of the same name | LL | let x = f.0.get_ref(); | ++ ``` instead of ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.rs:11:15 | LL | let x = f.get_ref(); | ^^^^^^^ method not found in `(BufReader<File>,)` | help: one of the expressions' fields has a method of the same name | LL | let x = f.0.get_ref(); | ++ help: consider pinning the expression | LL ~ let mut pinned = std::pin::pin!(f); LL ~ let x = pinned.as_ref().get_ref(); | ```

lcnr · 2025-08-08T12:53:14Z

@bors rü rollup

lcnr · 2025-08-08T12:53:32Z

@bors r+ rollup

bors · 2025-08-08T12:53:34Z

📌 Commit eace82c has been approved by lcnr

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - #139451 (Add `target_env = "macabi"` and `target_env = "sim"`) - #144039 (Use `tcx.short_string()` in more diagnostics) - #144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - #144545 (In rustc_pattern_analysis, put `true` witnesses before `false` witnesses) - #144579 (Implement declarative (`macro_rules!`) attribute macros (RFC 3697)) - #144649 (Account for bare tuples and `Pin` methods in field searching logic) - #144775 (more strongly dissuade use of `skip_binder`) - #144987 (Enable f16 and f128 on targets that were fixed in LLVM21) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144649 - estebank:issue-144602, r=lcnr Account for bare tuples and `Pin` methods in field searching logic When looking for the field names and types of a given type, account for tuples. This allows suggestions for incorrectly nested field accesses and field name typos to trigger as intended. Previously these suggestions only worked on `ty::Adt`, including tuple structs which are no different to tuples, so they should behave the same in suggestions. When suggesting field access which would encounter a method not found, do not suggest pinning when those methods are on `impl Pin` itself. ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.rs:11:15 | LL | let x = f.get_ref(); | ^^^^^^^ method not found in `(BufReader<File>,)` | help: one of the expressions' fields has a method of the same name | LL | let x = f.0.get_ref(); | ++ ``` instead of ``` error[E0599]: no method named `get_ref` found for tuple `(BufReader<File>,)` in the current scope --> $DIR/missing-field-access.rs:11:15 | LL | let x = f.get_ref(); | ^^^^^^^ method not found in `(BufReader<File>,)` | help: consider pinning the expression | LL ~ let mut pinned = std::pin::pin!(f); LL ~ let x = pinned.as_ref().get_ref(); | ``` Fix #144602.

Rollup of 8 pull requests Successful merges: - rust-lang/rust#139451 (Add `target_env = "macabi"` and `target_env = "sim"`) - rust-lang/rust#144039 (Use `tcx.short_string()` in more diagnostics) - rust-lang/rust#144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - rust-lang/rust#144545 (In rustc_pattern_analysis, put `true` witnesses before `false` witnesses) - rust-lang/rust#144579 (Implement declarative (`macro_rules!`) attribute macros (RFC 3697)) - rust-lang/rust#144649 (Account for bare tuples and `Pin` methods in field searching logic) - rust-lang/rust#144775 (more strongly dissuade use of `skip_binder`) - rust-lang/rust#144987 (Enable f16 and f128 on targets that were fixed in LLVM21) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 8 pull requests Successful merges: - rust-lang#139451 (Add `target_env = "macabi"` and `target_env = "sim"`) - rust-lang#144039 (Use `tcx.short_string()` in more diagnostics) - rust-lang#144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - rust-lang#144545 (In rustc_pattern_analysis, put `true` witnesses before `false` witnesses) - rust-lang#144579 (Implement declarative (`macro_rules!`) attribute macros (RFC 3697)) - rust-lang#144649 (Account for bare tuples and `Pin` methods in field searching logic) - rust-lang#144775 (more strongly dissuade use of `skip_binder`) - rust-lang#144987 (Enable f16 and f128 on targets that were fixed in LLVM21) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Jul 29, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 29, 2025

estebank changed the title ~~Account for bare tuples in field searching logic~~ Account for bare tuples and Pin methods in field searching logic Jul 29, 2025

lcnr reviewed Jul 30, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/expr.rs Show resolved Hide resolved

lcnr reviewed Jul 30, 2025

View reviewed changes

tests/ui/consts/issue-19244-1.stderr Outdated Show resolved Hide resolved

lcnr reviewed Jul 30, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/method/suggest.rs Outdated Show resolved Hide resolved

lcnr reviewed Aug 7, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/method/suggest.rs Outdated Show resolved Hide resolved

lcnr reviewed Aug 7, 2025

View reviewed changes

compiler/rustc_hir_typeck/src/expr.rs Outdated Show resolved Hide resolved

compiler/rustc_hir_typeck/src/expr.rs Outdated Show resolved Hide resolved

estebank added 4 commits August 7, 2025 21:39

Do not provide field typo suggestions for tuples and tuple structs

a17e8cf

review comment

eace82c

estebank force-pushed the issue-144602 branch from f47df01 to eace82c Compare August 7, 2025 21:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025

tgross35 mentioned this pull request Aug 8, 2025

Rollup of 8 pull requests #145126

Merged

bors merged commit d47f8ad into rust-lang:master Aug 9, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Account for bare tuples and `Pin` methods in field searching logic #144649

Account for bare tuples and `Pin` methods in field searching logic #144649

Uh oh!

estebank commented Jul 29, 2025 •

edited

Loading

Uh oh!

rustbot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

bors commented Aug 6, 2025

Uh oh!

Uh oh!

lcnr left a comment

Uh oh!

Uh oh!

Uh oh!

lcnr commented Aug 8, 2025

Uh oh!

lcnr commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Account for bare tuples and Pin methods in field searching logic #144649

Account for bare tuples and Pin methods in field searching logic #144649

Uh oh!

Conversation

estebank commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jul 30, 2025

Uh oh!

bors commented Aug 6, 2025

Uh oh!

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lcnr commented Aug 8, 2025

Uh oh!

lcnr commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Account for bare tuples and `Pin` methods in field searching logic #144649

Account for bare tuples and `Pin` methods in field searching logic #144649

estebank commented Jul 29, 2025 •

edited

Loading