Skip to content

Initialize mingw for the runner's user #144196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2025
Merged

Initialize mingw for the runner's user #144196

merged 1 commit into from
Jul 20, 2025

Conversation

ChrisDenton
Copy link
Member

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 19, 2025
@ChrisDenton
Copy link
Member Author

@bors2 try jobs=mingw,msvc

@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

⌛ Trying commit db1449a with merge 0854be6…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 19, 2025
@rust-bors
Auto merge of #144196 - ChrisDenton:init-mingw, r=<try>
0854be6 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
try-job: *mingw*
try-job: *msvc*
@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

💔 Test failed

@ChrisDenton
Copy link
Member Author

@bors2 try jobs=x86_64-mingw-,i686-mingw-,msvc

@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

⌛ Trying commit db1449a with merge 529e920…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 19, 2025
@rust-bors
Auto merge of #144196 - ChrisDenton:init-mingw, r=<try>
529e920 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
try-job: x86_64-mingw-
try-job: i686-mingw-
try-job: msvc
@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

💔 Test failed

@ChrisDenton
Copy link
Member Author

@bors2 try jobs=x86_64-mingw-,i686-mingw-,msvc

@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

⌛ Trying commit db1449a with merge 2ef2432…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jul 19, 2025
@rust-bors
Auto merge of #144196 - ChrisDenton:init-mingw, r=<try>
2ef2432 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
try-job: *x86_64-mingw-*
try-job: *i686-mingw-*
try-job: *msvc*
@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

💔 Test failed

@ChrisDenton
Copy link
Member Author

@bors2 try jobs=x86_64-mingw-,msvc

rust-bors bot added a commit that referenced this pull request Jul 19, 2025
@rust-bors
Auto merge of #144196 - ChrisDenton:init-mingw, r=<try>
3944185 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
try-job: *x86_64-mingw-*
try-job: *msvc*
@rust-bors
Copy link

rust-bors bot commented Jul 19, 2025

⌛ Trying commit db1449a with merge 3944185…

To cancel the try build, run the command @bors2 try cancel.

@mati865
Copy link
Member

mati865 commented Jul 19, 2025

I think these two should be equivalent. Once the directory is created the setup code should run in the next job...

...unless GitHub messed up the users again.

Anyway r=me for the current implementation once it passes CI.

@rust-bors
Copy link

rust-bors bot commented Jul 20, 2025

☀️ Try build successful (CI)
Build commit: 3944185 (39441855b4e7dafc33654f582cf1d09c66817ee7, parent: 0d9592026226f5a667a0da60c13b955e0b486a07)

@ChrisDenton
Copy link
Member Author

Fair enough. This is at least contained in the mingw script, so that's somewhat nicer.

r? mati865
@bors r=mati865 rollup

@bors
Copy link
Collaborator

bors commented Jul 20, 2025

📌 Commit db1449a has been approved by mati865

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 20, 2025
@ChrisDenton ChrisDenton marked this pull request as ready for review July 20, 2025 02:26
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025
@ChrisDenton ChrisDenton removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 20, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 20, 2025
@jhpratt
Rollup merge of rust-lang#144196 - ChrisDenton:init-mingw, r=mati865
43f7387 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
@jhpratt jhpratt mentioned this pull request Jul 20, 2025
Closed
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Jul 20, 2025
@fee1-dead
Rollup merge of rust-lang#144196 - ChrisDenton:init-mingw, r=mati865
a793976 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
@fee1-dead fee1-dead mentioned this pull request Jul 20, 2025
Closed
bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144204 - fee1-dead-contrib:rollup-56951om, r=fee1-dead
cbf0987 
Rollup of 12 pull requests

Successful merges:

 - #141260 (Allow volatile access to non-Rust memory, including address 0)
 - #143604 (Stabilize `const_float_round_methods`)
 - #143833 (Ban projecting into SIMD types [MCP838])
 - #143988 ([rustdoc] Make aliases search support partial matching)
 - #144078 (Fix debuginfo-lto-alloc.rs test)
 - #144111 (Remove deprecated `MaybeUninit` slice methods)
 - #144116 (Fixes for LLVM 21)
 - #144134 (Cleanup unicode table gen)
 - #144142 (Add implicit sized bound to trait ascription types)
 - #144148 (Remove pretty print hack for async blocks)
 - #144169 (interpret: fix TypeId pointers being considered data pointers)
 - #144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 20, 2025
Merged
bors added a commit that referenced this pull request Jul 20, 2025
@bors
Auto merge of #144208 - matthiaskrgr:rollup-wrli87h, r=matthiaskrgr
ca9eecd 
Rollup of 11 pull requests

Successful merges:

 - #141260 (Allow volatile access to non-Rust memory, including address 0)
 - #143604 (Stabilize `const_float_round_methods`)
 - #143988 ([rustdoc] Make aliases search support partial matching)
 - #144078 (Fix debuginfo-lto-alloc.rs test)
 - #144111 (Remove deprecated `MaybeUninit` slice methods)
 - #144116 (Fixes for LLVM 21)
 - #144134 (Cleanup unicode table gen)
 - #144142 (Add implicit sized bound to trait ascription types)
 - #144148 (Remove pretty print hack for async blocks)
 - #144169 (interpret: fix TypeId pointers being considered data pointers)
 - #144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit faefaa0 into rust-lang:master Jul 20, 2025
11 of 13 checks passed
rust-timer added a commit that referenced this pull request Jul 20, 2025
@rust-timer
Unrolled build for #144196
710ccfc 
Rollup merge of #144196 - ChrisDenton:init-mingw, r=mati865

Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
@rustbot rustbot added this to the 1.90.0 milestone Jul 20, 2025
@ChrisDenton ChrisDenton deleted the init-mingw branch July 20, 2025 13:08
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jul 21, 2025
@bors
Auto merge of #144208 - matthiaskrgr:rollup-wrli87h, r=matthiaskrgr
bc32ee0 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#141260 (Allow volatile access to non-Rust memory, including address 0)
 - rust-lang/rust#143604 (Stabilize `const_float_round_methods`)
 - rust-lang/rust#143988 ([rustdoc] Make aliases search support partial matching)
 - rust-lang/rust#144078 (Fix debuginfo-lto-alloc.rs test)
 - rust-lang/rust#144111 (Remove deprecated `MaybeUninit` slice methods)
 - rust-lang/rust#144116 (Fixes for LLVM 21)
 - rust-lang/rust#144134 (Cleanup unicode table gen)
 - rust-lang/rust#144142 (Add implicit sized bound to trait ascription types)
 - rust-lang/rust#144148 (Remove pretty print hack for async blocks)
 - rust-lang/rust#144169 (interpret: fix TypeId pointers being considered data pointers)
 - rust-lang/rust#144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#144196 - ChrisDenton:init-mingw, r=mati865
f642045 
Initialize mingw for the runner's user

This is apparently the more proper fix to https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Spurious.20bors.20CI.20failures/near/528915775

But let's see if it works.
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@bors @Muscraft
Auto merge of rust-lang#144208 - matthiaskrgr:rollup-wrli87h, r=matth…
6519063 
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#141260 (Allow volatile access to non-Rust memory, including address 0)
 - rust-lang#143604 (Stabilize `const_float_round_methods`)
 - rust-lang#143988 ([rustdoc] Make aliases search support partial matching)
 - rust-lang#144078 (Fix debuginfo-lto-alloc.rs test)
 - rust-lang#144111 (Remove deprecated `MaybeUninit` slice methods)
 - rust-lang#144116 (Fixes for LLVM 21)
 - rust-lang#144134 (Cleanup unicode table gen)
 - rust-lang#144142 (Add implicit sized bound to trait ascription types)
 - rust-lang#144148 (Remove pretty print hack for async blocks)
 - rust-lang#144169 (interpret: fix TypeId pointers being considered data pointers)
 - rust-lang#144196 (Initialize mingw for the runner's user)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mati865 mati865

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisDenton @mati865 @bors @rustbot