Rollup of 12 pull requests #143974

samueltardieu · 2025-07-15T15:14:52Z

Successful merges:

Support using const pointers in asm const operand #138618 (Support using const pointers in asm const operand)
wrapping shift: remove first bitmask and table #143355 (wrapping shift: remove first bitmask and table)
remote-test-client: Exit code 128 + <signal-number> instead of 3 #143448 (remote-test-client: Exit code 128 + <signal-number> instead of 3)
miri: fix out-of-bounds error for ptrs with negative offsets #143692 (miri: fix out-of-bounds error for ptrs with negative offsets)
Emit warning when there is no space between -o and arg #143719 (Emit warning when there is no space between -o and arg)
Move several float tests to floats/mod.rs #143738 (Move several float tests to floats/mod.rs)
Port #[coverage] to the new attribute system #143891 (Port #[coverage] to the new attribute system)
Make more of codegen_llvm safe #143920 (Make more of codegen_llvm safe)
Constify Index traits #143921 (Constify Index traits)
Make slice comparisons const #143925 (Make slice comparisons const)
Update mdbook to 0.4.52 #143948 (Update mdbook to 0.4.52)
Add tracing to InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr #143968 (Add tracing to InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr)

r? @ghost
@rustbot modify labels: rollup

If the remote process is terminated by a signal, make `remote-test-client` exit with the code `128 + <signal-number>` instead of always `3`. This follows common practice among tools such as bash [^1]: > When a command terminates on a fatal signal whose number is N, Bash uses the > value 128+N as the exit status. It also allows us to differentiate between `run-pass` and `run-crash` ui tests without special case code in compiletest for that when `remote-test-client` is used. [^1]: https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html

This is used for string interpolation currently, so rename it as so. The name `Const` will be used to denote a general CTFE constant that can either be integer or pointer.

This is intended for supporting passing arbitrary CTFE const into inline assembly.

`global_asm!` themselves don't need symbol names; they currently only have a symbol name during mono collecion to identify them to partitioning algorithm. However it will have shims generated under it which will need unique symbol names. The name themselves ultimately doesn't matter, so they're generated like other shim instances.

This is currently a no-op, but will be useful when const in `global_asm!` can be pointers.

Also make it *only* usable on nightly

Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0452 This primarily picks up a few fixes.

…crum Update mdbook to 0.4.52 Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0452 This primarily picks up a few fixes.

Add tracing to `InterpCx::fn_abi_of_instance/fn_abi_of_fn_ptr` This PR adds tracing to the `InterpCx::fn_abi_of_instance`/`::fn_abi_of_fn_ptr` functions by shadowing `FnAbiOf`'s trait methods with inherent methods on `InterpCx`, like done in rust-lang#142721. The reason why I am targeting these two functions is because they are used for Miri interpretation, and they make a `layout_of` query down the line without passing through the `layout_of` that was traced in rust-lang#142721. There are other places where `layout_of` is called without being traced (see the analysis below), but that's because the `Machine` used there is not `MiriMachine` but rather `CompileTimeMachine` which does not implement `enter_trace_span()`. But after discussing with `@RalfJung` we agreed that the const-eval part should not be traced together with Miri, that's why I am ignoring the other places where `layout_of` is called. r? `@RalfJung` <details><summary>Analysis of the places where <code>layout_of</code> is called</summary> I did some analysis for rust-lang#142721 (comment), and these are all the places where the query `tcx.layout_of` is called (directly or indirectly) outside of a traced `InterpCx::layout_of` while a program is being interpreted by Miri: ``` adjust_for_rust_scalar at ./compiler/rustc_ty_utils/src/abi.rs:302:35 {closure#2} at ./compiler/rustc_ty_utils/src/abi.rs:522:25 eval_body_using_ecx<> at ./compiler/rustc_const_eval/src/const_eval/eval_queries.rs:49:22 {closure#1}<> at ./compiler/rustc_const_eval/src/interpret/operand.rs:851:76 {closure#0}<> at ./compiler/rustc_const_eval/src/interpret/stack.rs:612:18 size_and_align at ./compiler/rustc_middle/src/mir/interpret/mod.rs:387:38 ``` I got these by: - patching rustc with this patch that adds a span to the `layout_of` query which prints the backtrace: [layout_of_other_places.diff.txt](https://github.com/user-attachments/files/21235523/layout_of_other_places.diff.txt) - adding this to my bootstrap.toml to have debug symbols inside the Miri binary: `rust.debuginfo-level = "line-tables-only"` and also `build.tool.miri.features = ["tracing"]` - obtaining a trace file with `MIRI_TRACING=1 ./x.py run miri --stage 1 --warnings warn --args src/tools/miri/tests/pass/hello.rs` (note: maybe using a file different than "src/tools/miri/tests/pass/hello.rs" would lead to more places where layout_of is called?) - running this query in Perfetto to select all `layout_of` spans that have as a direct parent a span named "frame" (as opposed to the parent being `InterpCx::layout_of`) and extract their backtrace: `select args.string_value from slice left join args on slice.arg_set_id = args.id where slice.name = "tcx.layout_of" and slice.parent_id in (select slice2.id from slice as slice2 where slice2.name = "frame") group by args.string_value` - exporting the data as `.tsv` and processing that file through this Python script. It finds the first path in the backtraces where "layout" isn't mentioned, which imo is a good heuristic to not consider `layout_of` wrappers/friends as call places, but rather go down the backtrace until an actual call place is reached. [layout_of_other_places.py.txt](https://github.com/user-attachments/files/21235529/layout_of_other_places.py.txt) </details>

samueltardieu · 2025-07-15T15:17:22Z

Strange, the GitHub CI hasn't triggered so far.

@bors r+ p=5 rollup=never

bors · 2025-07-15T15:17:26Z

📌 Commit 4e901b6 has been approved by samueltardieu

It is now in the queue for this repository.

samueltardieu · 2025-07-15T15:28:49Z

@bors r+ p=5 rollup=never

bors · 2025-07-15T15:28:53Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: std::vec: Add UB check for set_len, from_raw_parts_in, and etc. #143877

bors · 2025-07-15T15:28:54Z

📌 Commit 4e901b6 has been approved by samueltardieu

It is now in the queue for this repository.

rust-log-analyzer · 2025-07-15T15:37:37Z

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustc_hir_typeck v0.0.0 (/checkout/compiler/rustc_hir_typeck)
error: unnecessary `unsafe` block
   --> compiler/rustc_codegen_llvm/src/asm.rs:458:33
    |
458 | ...                   unsafe { llvm::LLVMSetGlobalConstant(g, llvm::True) };
    |                       ^^^^^^ unnecessary `unsafe` block
    |
    = note: `-D unused-unsafe` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(unused_unsafe)]`

samueltardieu · 2025-07-15T15:39:02Z

@bors r-

hkBst and others added 30 commits July 3, 2025 09:05

wrapping shift: remove first bitmask and table

f1b5a56

miri: fix out-of-bounds error for ptrs with negative offsets

9257894

Rename *AsmOperandRef::Const to Interpolate

c5fc208

This is used for string interpolation currently, so rename it as so. The name `Const` will be used to denote a general CTFE constant that can either be integer or pointer.

Add InlineAsmOperandRef::Const

34658b8

This is intended for supporting passing arbitrary CTFE const into inline assembly.

Implement asm_const_ptr for inline asm

83e7f93

Collect constants within global_asm! in collector

d7235e6

This is currently a no-op, but will be useful when const in `global_asm!` can be pointers.

Implement asm_const_ptr for global_asm and naked_asm

8da54fc

Consolidate infinity tests

cfb66e5

Consolidate test_num tests

c5e67b4

Consolidate neg_infinity tests

c2e6b39

Consolidate zero tests

0c01322

Consolidate negative zero tests

fc01eed

Consolidate one tests

868020e

Consolidate is_nan

1b8904c

Consolidate is_infinite tests

e3d8367

Consolidate is_finite tests

7dd2811

Consolidate is_normal tests

d2c1900

Consolidate classify tests

79769f2

Avoid a bunch of unnecessary unsafe blocks in cg_llvm

d3d51b4

Shrink some unsafe blocks in cg_llvm

e574fef

Merge typeid_metadata and create_metadata

b9baf63

Use context methods instead of directly calling FFI

56d22cd

Eliminate all direct uses of LLVMMDStringInContext2

7f95f04

Make Option const PartialEq

b363d84

Make NonZero const PartialEq

5d9c537

Make derive_const usable within libcore again

5d5b36d

Also make it *only* usable on nightly

Make slices [const] PartialEq

19c2f1b

Update mdbook to 0.4.52

02dc14b

Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0452 This primarily picks up a few fixes.

samueltardieu added 2 commits July 15, 2025 17:14

Rollup merge of rust-lang#143948 - ehuss:update-mdbook, r=Mark-Simula…

bdf3757

…crum Update mdbook to 0.4.52 Changelog: https://github.com/rust-lang/mdBook/blob/master/CHANGELOG.md#mdbook-0452 This primarily picks up a few fixes.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2025

samueltardieu closed this Jul 15, 2025

samueltardieu reopened this Jul 15, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 15, 2025

samueltardieu mentioned this pull request Jul 15, 2025

Make more of codegen_llvm safe #143920

Open

samueltardieu closed this Jul 15, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 15, 2025

samueltardieu deleted the rollup-6mj03ue branch July 15, 2025 15:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 12 pull requests #143974

Rollup of 12 pull requests #143974

Uh oh!

samueltardieu commented Jul 15, 2025 •

edited by rustbot

Loading

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

rust-log-analyzer commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

Uh oh!

Rollup of 12 pull requests #143974

Rollup of 12 pull requests #143974

Uh oh!

Conversation

samueltardieu commented Jul 15, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

bors commented Jul 15, 2025

Uh oh!

rust-log-analyzer commented Jul 15, 2025

Uh oh!

samueltardieu commented Jul 15, 2025

Uh oh!

Uh oh!

samueltardieu commented Jul 15, 2025 •

edited by rustbot

Loading