Rollup of 5 pull requests #143390

GuillaumeGomez · 2025-07-03T17:45:33Z

Successful merges:

rustdoc: fix attrs of locally reexported foreign items #141831 (rustdoc: fix attrs of locally reexported foreign items)
don't include .md in title #143364 (don't include .md in title)
Various refactorings to the metadata loader #143369 (Various refactorings to the metadata loader)
Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on {beta,stable}-accepted label application #143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on {beta,stable}-accepted label application)
Update browser-ui-test version to 0.21.1 #143384 (Update browser-ui-test version to 0.21.1)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

This allows all CrateLocator methods to take &self.

This makes it clearer when the locator and when crate_rejections is updated

This ensures they don't get out of sync

Add some dividing sections, as it was hard to quickly identify which section is which.

…rt-135092, r=GuillaumeGomez rustdoc: fix attrs of locally reexported foreign items fixes rust-lang#135092 also tweaks a few outdated/misleading comments. r? `@GuillaumeGomez`

…o, r=workingjubilee don't include `.md` in title its been bugging me

…=lcnr Various refactorings to the metadata loader

…aino Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application The first commit slightly reorganizes `triagebot.toml` (no functional changes) with some dividing sections, because I found it hard to find the actual sections. The second and third commit configures triagebot to post > PR #`{number}` has been **accepted** for **{beta,stable}** backport. to compiler/bootstrap backport threads respectively, when https://github.com/rust-lang/rust/labels/beta-accepted and https://github.com/rust-lang/rust/labels/stable-accepted labels are applied. Best reviewed commit-by-commit. cc `@Kobzol` r? `@apiraino`

…est, r=kobzol Update browser-ui-test version to `0.21.1` One day I'll find time and motivation to use `package.json` instead. 😆 r? `@Kobzol`

GuillaumeGomez · 2025-07-03T17:45:46Z

@bors r+ p=5 rollup=never

bors · 2025-07-03T17:45:49Z

📌 Commit 9092fbb has been approved by GuillaumeGomez

It is now in the queue for this repository.

bors · 2025-07-03T19:59:12Z

⌛ Testing commit 9092fbb with merge da58c05...

bors · 2025-07-03T23:15:55Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing da58c05 to master...

rust-timer · 2025-07-03T23:17:21Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#141831	rustdoc: fix attrs of locally reexported foreign items	`bacecc3eb4afaea2519f2e13482078088ebff340` (link)
#143364	don't include `.md` in title	`d2247472084bdbade5069f323717188230ca551e` (link)
#143369	Various refactorings to the metadata loader	`394b3f86e8ec408910081a28ab33480567c505f0` (link)
#143379	Post {beta,stable}-accepted notifications to compiler/boots…	`3380100d78d2f5353ed4889e218aa483506ed5fc` (link)
#143384	Update browser-ui-test version to `0.21.1`	`8b62958f8300536ae7939da917b76ee9a7c0de0b` (link)

previous master: 48aee7e383

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-07-03T23:19:11Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 48aee7e (parent) -> da58c05 (this PR)

Test differences

Show 3 test diffs

Stage 1

[rustdoc] tests/rustdoc/reexport/extern-135092.rs: [missing] -> pass (J1)

Stage 2

[rustdoc] tests/rustdoc/reexport/extern-135092.rs: [missing] -> pass (J0)

Additionally, 1 doctest diff were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard da58c051315268a197ce280f6ba07bbd03c66535 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-1: 7670.7s -> 10898.6s (42.1%)
x86_64-apple-2: 3986.1s -> 5528.6s (38.7%)
pr-check-1: 1848.7s -> 1597.4s (-13.6%)
aarch64-gnu-debug: 4154.8s -> 3592.7s (-13.5%)
x86_64-rust-for-linux: 3029.7s -> 2620.4s (-13.5%)
i686-gnu-2: 6373.0s -> 5536.2s (-13.1%)
tidy: 85.6s -> 74.4s (-13.1%)
i686-gnu-nopt-1: 8198.5s -> 7170.5s (-12.5%)
x86_64-gnu-distcheck: 8598.7s -> 7534.8s (-12.4%)
i686-gnu-1: 8427.4s -> 7501.4s (-11.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-log-analyzer · 2025-07-04T00:01:05Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Version: 4.2.2
Digest: sha256:ccb2698953eaebd21c7bf6268a94f9c26518a7e38e27e0b83c1fe1ad049819b1
Source commit SHA: 11bd71901bbe5b1630ceea73d27597364c9af683
##[endgroup]
Complete job name: DockerHub mirror
##[group]Run actions/checkout@v4
with:
  persist-credentials: false
  repository: rust-lang/rust
  token: ***
---
http.https://github.com/.extraheader
[command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
##[endgroup]
##[group]Run echo "***" | docker login ghcr.io -u rust-lang --password-stdin
echo "***" | docker login ghcr.io -u rust-lang --password-stdin
shell: /usr/bin/bash -e {0}
##[endgroup]
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
Post job cleanup.

rust-timer · 2025-07-04T09:21:49Z

Finished benchmarking commit (da58c05): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.2%, -0.2%]	8
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Max RSS (memory usage)

Results (secondary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.4%	[0.4%, 0.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 3.1%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.1%	[2.6%, 3.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 462.11s -> 462.222s (0.02%)
Artifact size: 372.18 MiB -> 372.18 MiB (-0.00%)

Kobzol · 2025-07-04T09:24:34Z

clap_derive bimodal noise.

@rustbot label: +perf-regression-triaged

lolbinarycat and others added 16 commits June 27, 2025 11:49

rustdoc: add regression test for issue 135092

f7321be

rustdoc: fix attrs of locally reexported foreign items

3ed1c87

don't include .md in title

2b0d2c4

Deduplicate getting the path of a lib candidate

121dac5

Pass CrateRejections separately from CrateLocator

8763305

This allows all CrateLocator methods to take &self.

Have a separate code path for -Zdual-proc-macro

57d6c1b

This makes it clearer when the locator and when crate_rejections is updated

Make most CrateLocator fields private

47caa0a

This ensures they don't get out of sync

[NFC] Re-organize triagebot.toml

091a798

Add some dividing sections, as it was hard to quickly identify which section is which.

Post {beta,stable}-accepted message to compiler backport threads

dc4ef56

Post {beta,stable}-accepted message to bootstrap backport threads

8ae4fc7

Update browser-ui-test version to 0.21.1

c246525

Rollup merge of rust-lang#141831 - lolbinarycat:rustdoc-extern-reexpo…

678ec9b

…rt-135092, r=GuillaumeGomez rustdoc: fix attrs of locally reexported foreign items fixes rust-lang#135092 also tweaks a few outdated/misleading comments. r? `@GuillaumeGomez`

Rollup merge of rust-lang#143364 - fee1-dead-contrib:push-pzymzusnzls…

990224b

…o, r=workingjubilee don't include `.md` in title its been bugging me

Rollup merge of rust-lang#143369 - bjorn3:cleanup_metadata_loading, r…

62a7fb0

…=lcnr Various refactorings to the metadata loader

Rollup merge of rust-lang#143384 - GuillaumeGomez:update-browser-ui-t…

9092fbb

…est, r=kobzol Update browser-ui-test version to `0.21.1` One day I'll find time and motivation to use `package.json` instead. 😆 r? `@Kobzol`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 3, 2025

bors merged commit da58c05 into rust-lang:master Jul 3, 2025
1 check passed

rustbot added this to the 1.90.0 milestone Jul 3, 2025

This was referenced Jul 4, 2025

Add relnotes-api-list in-tree tool #143053

Draft

Retire hir::*ItemRef. #143357

Merged

GuillaumeGomez deleted the rollup-2avj41s branch July 4, 2025 09:07

rustbot added the perf-regression Performance regression. label Jul 4, 2025

rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 5 pull requests #143390

Rollup of 5 pull requests #143390

Uh oh!

GuillaumeGomez commented Jul 3, 2025 •

edited by rustbot

Loading

Uh oh!

GuillaumeGomez commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Stage 1

Stage 2

Uh oh!

rust-log-analyzer commented Jul 4, 2025

Uh oh!

rust-timer commented Jul 4, 2025

Uh oh!

Kobzol commented Jul 4, 2025

Uh oh!

Uh oh!

Rollup of 5 pull requests #143390

Rollup of 5 pull requests #143390

Uh oh!

Conversation

GuillaumeGomez commented Jul 3, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GuillaumeGomez commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

Uh oh!

rust-timer commented Jul 3, 2025

Uh oh!

github-actions bot commented Jul 3, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-log-analyzer commented Jul 4, 2025

Uh oh!

rust-timer commented Jul 4, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Kobzol commented Jul 4, 2025

Uh oh!

Uh oh!

GuillaumeGomez commented Jul 3, 2025 •

edited by rustbot

Loading