loop match: error on #[const_continue] outside #[loop_match]
#143360
+115
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @WaffleLapkin. Use |
rustbot
added
S-waiting-on-review
WaffleLapkin
requested changes
Jul 4, 2025
| #[const_continue] | ||
| break State::A; | ||
| //~^ ERROR unlabeled `break` inside of a labeled block | ||
| //~| ERROR mismatched types |
There was a problem hiding this comment.
Where is mismatched types coming from?..
There was a problem hiding this comment.
the break is seen as a break from the loop with a value, and it's the final expression, so that value is returned, but the function's type says it'll return unit.
rustbot
added
S-waiting-on-author
folkertdev
force-pushed
the
const-continue-outside-loop-match
branch
from
8f4ff04 to
771373e
Compare
folkertdev
force-pushed
the
const-continue-outside-loop-match
branch
from
771373e to
7d0caef
Compare
folkertdev
commented
Jul 4, 2025
There was a problem hiding this comment.
Turns out there was a better way to do this at a much earlier stage. The logic now also properly handles shadowing labels (where the outer one is part of a loop_match but the inner one is not).
@rustbot ready
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue #132306
fixes #143119
fixes #143165
Fixes two ICEs because a panic was reachable.
@rustbot label +F-loop_match