-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Remove deprecated Error::description
impl from c_str::FromBytesWithNulError
#143326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9c1562
to
674724c
Compare
cc @rust-lang/libs — I'm 99% sure this is acceptable but I'd like to be positive. |
Consolidating the I have mixed feelings about dropping any existing |
Hm, I naïvely assumed that |
Right, |
I also assumed
Deprecation happened 46 stable versions ago, or almost 6 years ago. |
Sure, but AFAIK we haven't removed any of the existing overrides. If we're going to do that, I think it should be intentional and en masse. |
Should I open an issue to gauge opinions on that, or do you want to do it? Or do you have a better idea? |
Sure, if you're interested/motivated to make that happen, go ahead with an issue. |
Hi @hkBst, I believe @cuviper meant an API Change Proposal against the libs-team repo, as this (removing a user-visible deprecated override in |
Yes, and sorry, I should have offered that guidance. |
Given rust-lang/libs-team#615 (comment), perhaps this can now move forward? |
Error::description
impl from c_str::FromBytesWithNulError
That's sufficient for me. @bors r+ rollup |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
Rollup of 11 pull requests Successful merges: - #143326 (Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`) - #143431 (Use relative visibility when noting sealed trait to reduce false positive) - #143550 (resolve: Use interior mutability for extern module map) - #143631 (update to literal-escaper-0.0.5) - #143793 (Opaque type collection: Guard against endlessly recursing free alias types) - #143880 (tests: Test line debuginfo for linebreaked function parameters) - #143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - #143926 (Remove deprecated fields in bootstrap) - #143955 (Make frame spans appear on a separate trace line) - #143975 (type_id_eq: check that the hash fully matches the type) - #143984 (Fix ice for feature-gated `cfg` attributes applied to the crate) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #143326 - hkBst:rm-deprecated-1, r=jhpratt Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`
Rollup of 11 pull requests Successful merges: - rust-lang/rust#143326 (Remove deprecated `Error::description` impl from `c_str::FromBytesWithNulError`) - rust-lang/rust#143431 (Use relative visibility when noting sealed trait to reduce false positive) - rust-lang/rust#143550 (resolve: Use interior mutability for extern module map) - rust-lang/rust#143631 (update to literal-escaper-0.0.5) - rust-lang/rust#143793 (Opaque type collection: Guard against endlessly recursing free alias types) - rust-lang/rust#143880 (tests: Test line debuginfo for linebreaked function parameters) - rust-lang/rust#143914 (Reword mismatched-lifetime-syntaxes text based on feedback) - rust-lang/rust#143926 (Remove deprecated fields in bootstrap) - rust-lang/rust#143955 (Make frame spans appear on a separate trace line) - rust-lang/rust#143975 (type_id_eq: check that the hash fully matches the type) - rust-lang/rust#143984 (Fix ice for feature-gated `cfg` attributes applied to the crate) r? `@ghost` `@rustbot` modify labels: rollup
No description provided.