Skip to content

Avoid depending on forever-red DepNode when encoding metadata. #143247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2025
Merged

Avoid depending on forever-red DepNode when encoding metadata. #143247

merged 2 commits into from
Jul 4, 2025

Conversation

cjgillot
Copy link
Contributor

Split from #114669 for perf

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2025
bors added a commit that referenced this pull request Jun 30, 2025
@bors
Auto merge of #143247 - cjgillot:metadata-no-red, r=<try>
22d2c51 
Avoid depending on forever-red DepNode when encoding metadata.

Split from #114669 for perf

r? `@petrochenkov`
@bors
Copy link
Collaborator

bors commented Jun 30, 2025

⌛ Trying commit 1584b0e with merge 22d2c51...

petrochenkov
petrochenkov reviewed Jun 30, 2025
View reviewed changes
@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2025
@petrochenkov petrochenkov mentioned this pull request Jun 30, 2025
Merged
2 tasks
@bors
Copy link
Collaborator

bors commented Jun 30, 2025

☀️ Try build successful - checks-actions
Build commit: 22d2c51 (22d2c5105e640237ee0a534b4a7d84635a5b4480)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (22d2c51): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.7% [0.1%, 1.5%] 33
Regressions ❌
(secondary)		 0.5% [0.2%, 1.1%] 10
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [0.1%, 1.5%] 33

Max RSS (memory usage)

Results (primary 2.0%, secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.0% [0.6%, 7.0%] 7
Regressions ❌
(secondary)		 0.7% [0.7%, 0.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 2.0% [0.6%, 7.0%] 7

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.4%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.4% [0.0%, 2.2%] 76
Regressions ❌
(secondary)		 0.6% [0.0%, 3.3%] 36
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.0%, 2.2%] 76

Bootstrap: 694.099s -> 694.846s (0.11%)
Artifact size: 372.14 MiB -> 372.24 MiB (0.03%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 30, 2025
petrochenkov
petrochenkov reviewed Jul 1, 2025
View reviewed changes
@petrochenkov petrochenkov added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 1, 2025
@cjgillot
Copy link
Contributor Author

cjgillot commented Jul 1, 2025

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2025
bors added a commit that referenced this pull request Jul 1, 2025
@bors
Auto merge of #143247 - cjgillot:metadata-no-red, r=<try>
3797379 
Avoid depending on forever-red DepNode when encoding metadata.

Split from #114669 for perf

r? `@petrochenkov`
@bors
Copy link
Collaborator

bors commented Jul 1, 2025

⌛ Trying commit f12e837 with merge 3797379...

@bors
Copy link
Collaborator

bors commented Jul 1, 2025

☀️ Try build successful - checks-actions
Build commit: 3797379 (3797379f7091833992e5116135662ecd38c057d2)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3797379): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.5% [0.1%, 2.1%] 84
Regressions ❌
(secondary)		 1.2% [0.2%, 2.0%] 20
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -21.9% [-42.6%, -0.3%] 7
All ❌✅ (primary) 0.5% [0.1%, 2.1%] 84

Max RSS (memory usage)

Results (primary 0.4%, secondary -11.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.6% [1.0%, 2.3%] 3
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.4% [-3.4%, -3.4%] 1
Improvements ✅
(secondary)		 -11.4% [-15.0%, -8.4%] 6
All ❌✅ (primary) 0.4% [-3.4%, 2.3%] 4

Cycles

Results (primary -1.1%, secondary -5.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.7% [1.1%, 2.7%] 5
Regressions ❌
(secondary)		 3.3% [1.5%, 10.2%] 9
Improvements ✅
(primary)		 -2.0% [-3.0%, -1.4%] 15
Improvements ✅
(secondary)		 -17.5% [-37.9%, -2.1%] 7
All ❌✅ (primary) -1.1% [-3.0%, 2.7%] 20

Binary size

Results (primary 0.4%, secondary 0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.4% [0.0%, 2.2%] 76
Regressions ❌
(secondary)		 0.6% [0.0%, 3.3%] 36
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.4% [0.0%, 2.2%] 76

Bootstrap: 460.931s -> 461.575s (0.14%)
Artifact size: 372.21 MiB -> 372.24 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 1, 2025
@petrochenkov
Copy link
Contributor

This is actually a smaller regression than I was expecting.
And the cases in which the resolutions(()) stay green (I assume) give a huge speedup.

And this can likely be sped up further

  • by not hashing visibilities_for_hashing and maybe some other fields twice.
  • by un-querifying other cheap accesses to tables in ResolverGlobalCtxt

I think the doc_link_resolutions change can also be reverted now.

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

⌛ Testing commit 992fa62 with merge 556d20a...

@bors
Copy link
Collaborator

bors commented Jul 4, 2025

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 556d20a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2025
@bors bors merged commit 556d20a into rust-lang:master Jul 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1b61d43 (parent) -> 556d20a (this PR)

Test differences

Show 114 test diffs

114 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 556d20a834126d2d0ac20743b9792b8474d6d03c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 4405.8s -> 7528.2s (70.9%)
  2. dist-apple-various: 5891.6s -> 7112.6s (20.7%)
  3. dist-armhf-linux: 5537.5s -> 4625.2s (-16.5%)
  4. dist-x86_64-apple: 7616.3s -> 8467.6s (11.2%)
  5. dist-riscv64-linux: 4956.1s -> 4425.2s (-10.7%)
  6. dist-arm-linux-gnueabi: 5089.4s -> 4577.6s (-10.1%)
  7. dist-aarch64-apple: 4739.7s -> 5199.0s (9.7%)
  8. dist-x86_64-windows-gnullvm: 5954.9s -> 5403.3s (-9.3%)
  9. dist-powerpc-linux: 5315.3s -> 4884.8s (-8.1%)
  10. dist-powerpc64le-linux-musl: 5395.3s -> 4961.5s (-8.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143371 - cjgillot:prehash-visibilities, r=<try>
556648c 
Prehash visibilities in resolver

Based on #143247
r? `@ghost` for perf
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143373 - cjgillot:bare-unused-trait-imports, r=<try>
891c2a6 
Unquerify maybe_unused_trait_imports.

Based on #143247
r? `@ghost` for perf
bors added a commit that referenced this pull request Jul 4, 2025
@bors
Auto merge of #143374 - cjgillot:bare-extern-crate-map, r=<try>
660c02e 
Unquerify extern_mod_stmt_cnum.

Based on #143247
r? `@ghost` for perf
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (556d20a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.6% [0.2%, 2.0%] 61
Regressions ❌
(secondary)		 1.1% [0.2%, 2.1%] 21
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -25.5% [-42.6%, -16.4%] 6
All ❌✅ (primary) 0.6% [0.2%, 2.0%] 61

Max RSS (memory usage)

Results (primary 1.8%, secondary -7.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.8% [1.7%, 2.0%] 2
Regressions ❌
(secondary)		 0.8% [0.8%, 0.8%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -8.4% [-13.8%, -0.4%] 8
All ❌✅ (primary) 1.8% [1.7%, 2.0%] 2

Cycles

Results (secondary -13.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.8% [1.0%, 2.6%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -19.5% [-38.2%, -3.3%] 7
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 462.82s -> 461.146s (-0.36%)
Artifact size: 372.13 MiB -> 372.20 MiB (0.02%)

@cjgillot cjgillot deleted the metadata-no-red branch July 4, 2025 16:05
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#143372 - cjgillot:bare-glob-map, r=petroche…
089c33e 
…nkov

Remove names_imported_by_glob_use query.

Based on rust-lang#143247
r? `@ghost` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#143372 - cjgillot:bare-glob-map, r=petroche…
031bf97 
…nkov

Remove names_imported_by_glob_use query.

Based on rust-lang#143247
r? ``@ghost`` for perf
rust-timer added a commit that referenced this pull request Jul 5, 2025
@rust-timer
Unrolled build for #143372
141301c 
Rollup merge of #143372 - cjgillot:bare-glob-map, r=petrochenkov

Remove names_imported_by_glob_use query.

Based on #143247
r? ``@ghost`` for perf
@panstromek
Copy link
Contributor

perf triage:

Regressions are expected and as per #143247 (comment) and following comments, will be investigated in a followup.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jul 7, 2025
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jul 10, 2025
@matthiaskrgr
Rollup merge of #143372 - cjgillot:bare-glob-map, r=petrochenkov
daf9adb 
Remove names_imported_by_glob_use query.

Based on rust-lang/rust#143247
r? ``@ghost`` for perf
Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
@matthiaskrgr @Muscraft
Rollup merge of rust-lang#143372 - cjgillot:bare-glob-map, r=petroche…
d1be47b 
…nkov

Remove names_imported_by_glob_use query.

Based on rust-lang#143247
r? ``@ghost`` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#143373 - cjgillot:bare-unused-trait-imports…
0a48304 
…, r=petrochenkov

Unquerify maybe_unused_trait_imports.

Based on rust-lang#143247
r? `@ghost` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#143373 - cjgillot:bare-unused-trait-imports…
8a4f1ce 
…, r=petrochenkov

Unquerify maybe_unused_trait_imports.

Based on rust-lang#143247
r? ``@ghost`` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#143373 - cjgillot:bare-unused-trait-imports…
b934f1a 
…, r=petrochenkov

Unquerify maybe_unused_trait_imports.

Based on rust-lang#143247
r? ```@ghost``` for perf
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 22, 2025
@matthiaskrgr
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
08aaa14 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? `@ghost` for perf
rust-timer added a commit that referenced this pull request Jul 22, 2025
@rust-timer
Unrolled build for #143373
ab89d8e 
Rollup merge of #143373 - cjgillot:bare-unused-trait-imports, r=petrochenkov

Unquerify maybe_unused_trait_imports.

Based on #143247
r? ```@ghost``` for perf
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
aab76e7 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? `@ghost` for perf
fmease added a commit to fmease/rust that referenced this pull request Jul 23, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
8469ec1 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ``@ghost`` for perf
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
bd914d0 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ```@ghost``` for perf
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
6f0d38e 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? ````@ghost```` for perf
fmease added a commit to fmease/rust that referenced this pull request Jul 24, 2025
@fmease
Rollup merge of rust-lang#143374 - cjgillot:bare-extern-crate-map, r=…
404f904 
…petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on rust-lang#143247
r? `````@ghost````` for perf
rust-timer added a commit that referenced this pull request Jul 24, 2025
@rust-timer
Unrolled build for #143374
83a2eb9 
Rollup merge of #143374 - cjgillot:bare-extern-crate-map, r=petrochenkov

Unquerify extern_mod_stmt_cnum.

Based on #143247
r? `````@ghost````` for perf
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Jul 25, 2025
@matthiaskrgr
Rollup merge of #143373 - cjgillot:bare-unused-trait-imports, r=petro…
3ed170f 
…chenkov

Unquerify maybe_unused_trait_imports.

Based on rust-lang/rust#143247
r? ```@ghost``` for perf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rust-timer @bors @petrochenkov @panstromek @rustbot