Fix typo in libcore #14292
Merged
Fix typo in libcore #14292
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
May 19, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 26, 2025
~~I've added a `min_divisor` configuration option, default to 4, to not trigger on smaller divisibility operations. I would prefer not to lint `if a & 1 == 0` as `if a.is_multiple_of(2)` by default because the former is very idiomatic in systems (and embedded) programming.~~ ~~A `min_and_mask_size` option, defaulting to 3, sets the default bits to be and-masked before this lint triggers; that would be `n` in `v & ((1 << n) - 1) == 0`. The form `v % 10 == 0` is always linted.~~ ~~This PR will stay in draft mode until the next rustup which will mark `unsigned_is_multiple_of` stable for Rust 1.87.0, and the feature flags will be removed.~~ What should its category be? I've used "complexity", but "pedantic" might be suitable as well. Close rust-lang/rust-clippy#14289 changelog: [`manual_is_multiple_of`]: new lint r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.