Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation #142647

compiler-errors · 2025-06-17T21:35:49Z

First compute hard errors without diagnostics, then ambiguities with diagnostics since we need to know if any of them overflowed.

compiler-errors · 2025-06-17T21:35:56Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-17T21:36:00Z

⌛ Trying commit 15a8f83 with merge f6e2337…

To cancel the try build, run the command @bors2 try cancel.

[perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation

rust-bors · 2025-06-18T00:06:11Z

☀️ Try build successful (CI)
Build commit: f6e2337 (f6e233705a1a56780a1d4f57fb6b14373f60468c, parent: f3db63916e541ff039ac3cd7364c2d612749b61b)

rust-timer · 2025-06-18T23:20:26Z

Finished benchmarking commit (f6e2337): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 692.654s -> 692.684s (0.00%)
Artifact size: 372.15 MiB -> 372.15 MiB (-0.00%)

compiler-errors · 2025-06-20T19:09:00Z

I think it's still worth landing 👍 could be worse in pathological cases.

rustbot · 2025-06-20T19:09:09Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

compiler-errors · 2025-06-20T19:13:15Z

tests/crashes/139905.rs

@@ -1,6 +0,0 @@
-//@ known-bug: #139905


Coincidentally fixes this error. I'll put up a correct fix.

lcnr · 2025-06-22T18:44:25Z

compiler/rustc_trait_selection/src/traits/coherence.rs

+
+        // Make a new `ObligationCtxt` and re-prove the ambiguities with a richer
+        // `FulfillmentError`. This is so that we can detect overflowing obligations
+        // without needing to run the `BestBestObligation` visitor on true errors.


Suggested change

// without needing to run the `BestBestObligation` visitor on true errors.

// without needing to run the `BestObligation` visitor on true errors.

lcnr · 2025-06-22T18:44:58Z

@bors r+ rollup

bors · 2025-06-22T18:45:01Z

📌 Commit 15a8f83 has been approved by lcnr

It is now in the queue for this repository.

lcnr · 2025-06-22T18:45:04Z

@bors rollup=never

compiler-errors · 2025-06-22T18:46:20Z

meow ill fix it when im back from the beach :3 ty for the review

@bors r-

…ssible_obligation

compiler-errors · 2025-06-25T15:33:03Z

@bors r=lcnr rollup

bors · 2025-06-25T15:33:06Z

📌 Commit 8304435 has been approved by lcnr

It is now in the queue for this repository.

…ence, r=lcnr [perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation First compute hard errors without diagnostics, then ambiguities with diagnostics since we need to know if any of them overflowed.

Rollup of 17 pull requests Successful merges: - #124595 (Suggest cloning `Arc` moved into closure) - #139594 (Simplify `ObligationCauseCode::IfExpression`) - #141311 (make `tidy-alphabetical` use a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion) - #142255 (Add edition checks for some tests that had divergent output) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142884 (StableMIR: Add method to retrieve body of coroutine) - #142925 (Rewrite `.gitattributes` CRLF ui tests into run-make tests) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143020 (codegen_fn_attrs: make comment more precise) - #143033 (Expand const-stabilized API links in relnotes) r? `@ghost` `@rustbot` modify labels: rollup

…ence, r=lcnr [perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation First compute hard errors without diagnostics, then ambiguities with diagnostics since we need to know if any of them overflowed.

…rors Rollup of 18 pull requests Successful merges: - #137843 (make RefCell unstably const) - #140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142927 (Add note to `find_const_ty_from_env`) - #142967 (Fix RwLock::try_write documentation for WouldBlock condition) - #142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143033 (Expand const-stabilized API links in relnotes) - #143041 (Remove cache for citool) - #143056 (Move an ACE test out of the GCI directory) - #143059 (Fix 1.88 relnotes) - #143067 (Tracking issue number for `iter_macro`) - #143073 (Fix some fixmes that were waiting for let chains) Failed merges: - #143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #142647 - compiler-errors:less-work-in-coherence, r=lcnr [perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation First compute hard errors without diagnostics, then ambiguities with diagnostics since we need to know if any of them overflowed.

…mpiler-errors Rollup of 18 pull requests Successful merges: - rust-lang#137843 (make RefCell unstably const) - rust-lang#140942 (const-eval: allow constants to refer to mutable/external memory, but reject such constants as patterns) - rust-lang#142549 (small iter.intersperse.fold() optimization) - rust-lang#142637 (Remove some glob imports from the type system) - rust-lang#142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - rust-lang#142700 (Remove incorrect comments in `Weak`) - rust-lang#142927 (Add note to `find_const_ty_from_env`) - rust-lang#142967 (Fix RwLock::try_write documentation for WouldBlock condition) - rust-lang#142986 (Port `#[export_name]` to the new attribute parsing infrastructure) - rust-lang#143001 (Rename run always ) - rust-lang#143010 (Update `browser-ui-test` version to `0.20.7`) - rust-lang#143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - rust-lang#143033 (Expand const-stabilized API links in relnotes) - rust-lang#143041 (Remove cache for citool) - rust-lang#143056 (Move an ACE test out of the GCI directory) - rust-lang#143059 (Fix 1.88 relnotes) - rust-lang#143067 (Tracking issue number for `iter_macro`) - rust-lang#143073 (Fix some fixmes that were waiting for let chains) Failed merges: - rust-lang#143020 (codegen_fn_attrs: make comment more precise) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 17, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 17, 2025

Auto merge of #142647 - compiler-errors:less-work-in-coherence, r=<try>

f6e2337

[perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 17, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 18, 2025

compiler-errors assigned lcnr Jun 20, 2025

compiler-errors marked this pull request as ready for review June 20, 2025 19:09

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2025

compiler-errors commented Jun 20, 2025

View reviewed changes

lcnr reviewed Jun 22, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2025

Compute hard errors without diagnostics in impl_intersection_has_impo…

8304435

…ssible_obligation

compiler-errors force-pushed the less-work-in-coherence branch from 15a8f83 to 8304435 Compare June 25, 2025 15:32

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 25, 2025

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 25, 2025

workingjubilee mentioned this pull request Jun 26, 2025

Rollup of 17 pull requests #143039

Closed

This was referenced Jun 26, 2025

Rollup of 19 pull requests #143061

Closed

Rollup of 18 pull requests #143074

Merged

bors merged commit 25e239c into rust-lang:master Jun 27, 2025
10 checks passed

rustbot added this to the 1.90.0 milestone Jun 27, 2025

lcnr changed the title ~~[perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation~~ Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation Jun 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation #142647

Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation #142647

compiler-errors commented Jun 17, 2025 •

edited

Loading

Uh oh!

compiler-errors commented Jun 17, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 18, 2025

Uh oh!

compiler-errors commented Jun 20, 2025

Uh oh!

rustbot commented Jun 20, 2025

Uh oh!

compiler-errors Jun 20, 2025

Uh oh!

lcnr Jun 22, 2025

Uh oh!

lcnr commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

lcnr commented Jun 22, 2025

Uh oh!

compiler-errors commented Jun 22, 2025

Uh oh!

compiler-errors commented Jun 25, 2025

Uh oh!

bors commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

	// without needing to run the `BestBestObligation` visitor on true errors.
	// without needing to run the `BestObligation` visitor on true errors.

Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation #142647

Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation #142647

Conversation

compiler-errors commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Jun 17, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 18, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 18, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

compiler-errors commented Jun 20, 2025

Uh oh!

rustbot commented Jun 20, 2025

Uh oh!

compiler-errors Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

lcnr Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

lcnr commented Jun 22, 2025

Uh oh!

bors commented Jun 22, 2025

Uh oh!

lcnr commented Jun 22, 2025

Uh oh!

compiler-errors commented Jun 22, 2025

Uh oh!

compiler-errors commented Jun 25, 2025

Uh oh!

bors commented Jun 25, 2025

Uh oh!

Uh oh!

Uh oh!

compiler-errors commented Jun 17, 2025 •

edited

Loading