Skip to content

Fix missing newline trim in bootstrap #142374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Fix missing newline trim in bootstrap #142374

merged 1 commit into from
Jun 12, 2025

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 11, 2025 •
edited
Loading

Fixes this comment.

Fixes: #142350

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

Failed to set assignee to onur-ozkan: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 11, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol Kobzol mentioned this pull request Jun 11, 2025
Merged
@Kobzol
Copy link
Member Author

Kobzol commented Jun 11, 2025

r? @jieyouxu

@Kobzol Kobzol mentioned this pull request Jun 11, 2025
Closed
@Kobzol
Copy link
Member Author

Kobzol commented Jun 11, 2025

@bors r=tmiasko

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit ad76318 has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
@Kobzol
Copy link
Member Author

Kobzol commented Jun 11, 2025

@bors rollup

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kobzol
Copy link
Member Author

Kobzol commented Jun 11, 2025

@bors r-

Sigh.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 11, 2025
@tmiasko
Copy link
Contributor

tmiasko commented Jun 11, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit 87b068c has been approved by tmiasko

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 11, 2025
Merged
bors added a commit that referenced this pull request Jun 11, 2025
@bors
Auto merge of #142381 - matthiaskrgr:rollup-si4xbko, r=matthiaskrgr
31d0d21 
Rollup of 9 pull requests

Successful merges:

 - #142305 (Remove unneeded `check_id` calls as they are already called in `visit_id` in `EarlyContextAndPass` type)
 - #142314 (remove ice group pings from `triagebot.toml`)
 - #142343 (remove myself from the project)
 - #142346 (Add tracing import to execution context)
 - #142356 (Fix enter_trace_span!() using wrong $crate paths)
 - #142362 (Add expectation for `{` when parsing lone coroutine qualifiers)
 - #142364 (Do not warn on `rust.incremental` when using download CI rustc)
 - #142369 (Improve some attribute docs and rename groups)
 - #142374 (Fix missing newline trim in bootstrap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c97dca6 into rust-lang:master Jun 12, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 12, 2025
@rust-timer
Unrolled build for #142374
d71dba4 
Rollup merge of #142374 - Kobzol:fix-newline, r=tmiasko

Fix missing newline trim in bootstrap

Fixes [this comment](https://github.com/rust-lang/rust/pull/141909/files#r2140632918).

Fixes: #142350
@rustbot rustbot added this to the 1.89.0 milestone Jun 12, 2025
@Kobzol Kobzol deleted the fix-newline branch June 12, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmiasko tmiasko tmiasko approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

Weird errors when running ./x.py test?
6 participants
@Kobzol @rustbot @bors @rust-log-analyzer @tmiasko @jieyouxu