Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Jun 9, 2025

Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux -alt builds.

r? @ghost

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2025

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@Kobzol
Copy link
Member Author

Kobzol commented Jun 9, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

⌛ Trying commit fea114c with merge 719c0f0

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 9, 2025
Rustc dist alt assertions

Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds.

r? `@ghost`

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt
@Kobzol Kobzol changed the title Rustc dist alt assertions Build rustc with assertions in dist-alt jobs Jun 9, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

☀️ Try build successful (CI)
Build commit: 719c0f0 (719c0f0e93c1f3606edfa5381222b9d9b8b0c087)

@Kobzol
Copy link
Member Author

Kobzol commented Jun 9, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

⌛ Trying commit 6d4df2d with merge 6acdc26

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 9, 2025
Build rustc with assertions in `dist-alt` jobs

Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds.

r? `@ghost`

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt
@rust-bors
Copy link

rust-bors bot commented Jun 9, 2025

☀️ Try build successful (CI)
Build commit: 6acdc26 (6acdc261c9a2a67217d87dea62949057a09f503f)

@Kobzol
Copy link
Member Author

Kobzol commented Jun 9, 2025

2h 14 minutes with the 8-core runner, pretty nice. @marcoieni would you be fine to switch the dist-alt runner to 8 cores in order to get rustc assertions in CI builds?

@marcoieni
Copy link
Member

2h 14 minutes with the 8-core runner, pretty nice. @marcoieni would you be fine to switch the dist-alt runner to 8 cores in order to get rustc assertions in CI builds?

yes it's fine 👍

lqd and others added 2 commits June 10, 2025 12:17
llvm assertions are already enabled and debug assertions are also useful
@Kobzol Kobzol force-pushed the rustc-dist-alt-assertions branch from 6d4df2d to 607a567 Compare June 10, 2025 10:17
@Kobzol
Copy link
Member Author

Kobzol commented Jun 10, 2025

@bors2 try

rust-bors bot added a commit that referenced this pull request Jun 10, 2025
Build rustc with assertions in `dist-alt` jobs

Revival of #131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds.

r? `@ghost`

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt
@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

⌛ Trying commit 607a567 with merge 11c9e81

To cancel the try build, run the command @bors2 try cancel.

@rust-bors
Copy link

rust-bors bot commented Jun 10, 2025

☀️ Try build successful (CI)
Build commit: 11c9e81 (11c9e81093a637885ff88d565c318d0b9c074c63)

@Kobzol
Copy link
Member Author

Kobzol commented Jun 10, 2025

r? @marcoieni

@marcoieni
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 10, 2025

📌 Commit 607a567 has been approved by marcoieni

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2025
fmease added a commit to fmease/rust that referenced this pull request Jun 10, 2025
…r=marcoieni

Build rustc with assertions in `dist-alt` jobs

Revival of rust-lang#131077, to check CI times now that we don't do PGO/BOLT anymore on Linux `-alt` builds.

r? `@ghost`

try-job: dist-x86_64-msvc-alt
try-job: dist-x86_64-linux-alt
bors added a commit that referenced this pull request Jun 11, 2025
Rollup of 13 pull requests

Successful merges:

 - #128425 (Make `missing_fragment_specifier` an unconditional error)
 - #141639 (Expose discriminant values in stable_mir)
 - #141967 (Configure bootstrap backport nominations through triagebot)
 - #142042 (Make E0621 missing lifetime suggestion verbose)
 - #142176 (tests: Split dont-shuffle-bswaps along opt-levels and arches)
 - #142235 (Build rustc with assertions in `dist-alt` jobs)
 - #142248 (Add supported asm types for LoongArch32)
 - #142272 (tests: Change ABIs in tests to more future-resilient ones)
 - #142282 (Only run `citool` tests on the `auto` branch)
 - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats)
 - #142297 (Implement `//@ needs-target-std` compiletest directive)
 - #142298 (Make loongarch-none target maintainers more easily pingable)
 - #142306 (Dont unwrap and re-wrap typing envs)

Failed merges:

 - #141942 (Implement representation options to smir)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee
Copy link
Member

sorry, I don't have a good reason, it just has a vibe, and I think everyone else is assuming it does too.

@bors rollup=iffy

@bors
Copy link
Collaborator

bors commented Jun 14, 2025

⌛ Testing commit 607a567 with merge 64c81fd...

@bors
Copy link
Collaborator

bors commented Jun 14, 2025

☀️ Test successful - checks-actions
Approved by: marcoieni
Pushing 64c81fd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 14, 2025
@bors bors merged commit 64c81fd into rust-lang:master Jun 14, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 14, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d087f11 (parent) -> 64c81fd (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 64c81fd10509924ca4da5d93d6052a65b75418a5 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3428.9s -> 5893.1s (71.9%)
  2. dist-x86_64-apple: 7706.6s -> 9773.4s (26.8%)
  3. dist-x86_64-linux-alt: 9526.9s -> 7293.1s (-23.4%)
  4. aarch64-apple: 4330.2s -> 5259.7s (21.5%)
  5. dist-x86_64-msvc-alt: 7142.8s -> 8375.8s (17.3%)
  6. aarch64-gnu-debug: 3575.9s -> 4064.3s (13.7%)
  7. dist-arm-linux-gnueabi: 4555.5s -> 5160.7s (13.3%)
  8. x86_64-apple-1: 6185.4s -> 6946.8s (12.3%)
  9. i686-gnu-2: 5391.9s -> 6044.3s (12.1%)
  10. mingw-check-1: 1677.9s -> 1860.1s (10.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Kobzol Kobzol deleted the rustc-dist-alt-assertions branch June 14, 2025 06:18
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (64c81fd): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%, secondary -5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.6% [-3.6%, -1.6%] 2
Improvements ✅
(secondary)
-5.7% [-8.2%, -3.3%] 2
All ❌✅ (primary) -2.6% [-3.6%, -1.6%] 2

Cycles

Results (secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.7% [1.7%, 1.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.156s -> 757.551s (0.05%)
Artifact size: 372.29 MiB -> 372.30 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants