Dont make ObligationCtxts with diagnostics unnecessarily
#142222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rustbot
added
the
S-waiting-on-review
|
Some changes occurred to constck cc @fee1-dead Some changes occurred to the CTFE machinery |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
r? lcnr |
bors
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup of 7 pull requests Successful merges: - #129121 (Stabilize `tcp_quickack`) - #142192 (De-duplicate f16 & f128 doctest attributes) - #142193 (add tests for pattern binding drop order edge cases) - #142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - #142228 (rustc-dev-guide subtree update) - #142231 (Run `calculate_matrix` job on `master` to cache citool builds) - #142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jun 9, 2025
Rollup merge of #142222 - compiler-errors:ocx-w-no-diag, r=lcnr Dont make `ObligationCtxt`s with diagnostics unnecessarily just a nit, shouldn't affect perf b/c `ObligationCtxt::new_with_diagnostics` should only be more expensive in the new trait solver, and I don't expect either of these to encounter errors today anyways. r? oli-obk
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 12, 2025
Rollup of 7 pull requests Successful merges: - rust-lang/rust#129121 (Stabilize `tcp_quickack`) - rust-lang/rust#142192 (De-duplicate f16 & f128 doctest attributes) - rust-lang/rust#142193 (add tests for pattern binding drop order edge cases) - rust-lang/rust#142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - rust-lang/rust#142228 (rustc-dev-guide subtree update) - rust-lang/rust#142231 (Run `calculate_matrix` job on `master` to cache citool builds) - rust-lang/rust#142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
tautschnig
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 17, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129121 (Stabilize `tcp_quickack`) - rust-lang#142192 (De-duplicate f16 & f128 doctest attributes) - rust-lang#142193 (add tests for pattern binding drop order edge cases) - rust-lang#142222 (Dont make `ObligationCtxt`s with diagnostics unnecessarily) - rust-lang#142228 (rustc-dev-guide subtree update) - rust-lang#142231 (Run `calculate_matrix` job on `master` to cache citool builds) - rust-lang#142232 (add `Cargo.lock` to CI-rustc allowed list for non-CI env) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a nit, shouldn't affect perf b/c
ObligationCtxt::new_with_diagnosticsshould only be more expensive in the new trait solver, and I don't expect either of these to encounter errors today anyways.r? oli-obk