Skip to content

allow macro_use as first segment #141884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

allow macro_use as first segment #141884

merged 1 commit into from
Jun 2, 2025

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 2, 2025 •
edited by rustbot
Loading

Fixes #140255

This issue may raise a question: It's reasonable an external crate name or import target be legally named macro_use?

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

This issue may raise a question: It's reasonable an external crate name or import target be legally named macro_use?

Absolutely, macro_use is not reserved, it's just a name of a built-in attribute. There are several dozens of such attributes, we don't want to report naming conflicts for all of them in non-macro namespaces.

@bors
Copy link
Collaborator

bors commented Jun 2, 2025

📌 Commit 9b94cae has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 2, 2025
@chenyukang chenyukang mentioned this pull request Jun 2, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#141884 - bvanjoi:issue-140255, r=petrochenkov
0237b2d 
allow macro_use as first segment

Fixes rust-lang#140255

This issue may raise a question: It's reasonable an external crate name or import target be legally named `macro_use`?
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 2, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 2, 2025
@matthiaskrgr
Rollup merge of rust-lang#141884 - bvanjoi:issue-140255, r=petrochenkov
cdb674b 
allow macro_use as first segment

Fixes rust-lang#140255

This issue may raise a question: It's reasonable an external crate name or import target be legally named `macro_use`?
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 2, 2025
Closed
bors added a commit that referenced this pull request Jun 2, 2025
@bors
Auto merge of #141906 - chenyukang:rollup-k6v59ty, r=chenyukang
449c801 
Rollup of 6 pull requests

Successful merges:

 - #141884 (allow macro_use as first segment)
 - #141885 ([RTE-484] Update SGX maintainers)
 - #141892 (Fix false positive lint error from no_implicit_prelude attr)
 - #141894 (rustc-dev-guide subtree update)
 - #141895 (tshepang has a new email)
 - #141897 (Fix citool tests when executed locally)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8d9fc03 into rust-lang:master Jun 2, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 2, 2025
rust-timer added a commit that referenced this pull request Jun 2, 2025
@rust-timer
Unrolled build for #141884
a2ba155 
Rollup merge of #141884 - bvanjoi:issue-140255, r=petrochenkov

allow macro_use as first segment

Fixes #140255

This issue may raise a question: It's reasonable an external crate name or import target be legally named `macro_use`?
jieyouxu pushed a commit to jieyouxu/rustc-dev-guide that referenced this pull request Jun 3, 2025
@bors
Auto merge of #141906 - chenyukang:rollup-k6v59ty, r=chenyukang
93a0856 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#141884 (allow macro_use as first segment)
 - rust-lang/rust#141885 ([RTE-484] Update SGX maintainers)
 - rust-lang/rust#141892 (Fix false positive lint error from no_implicit_prelude attr)
 - rust-lang/rust#141894 (rustc-dev-guide subtree update)
 - rust-lang/rust#141895 (tshepang has a new email)
 - rust-lang/rust#141897 (Fix citool tests when executed locally)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

ICE: compiler/rustc_passes/src/check_attr.rs None
4 participants
@bvanjoi @rustbot @petrochenkov @bors